static build on cygwin/mingw broken (should not link Urlmon)

RESOLVED FIXED in mozilla1.9alpha1

Status

Firefox Build System
General
RESOLVED FIXED
14 years ago
2 months ago

People

(Reporter: Hans-Andreas Engel, Unassigned)

Tracking

Trunk
mozilla1.9alpha1
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

14 years ago
Building a static version of firefox (probably the same for mozilla) does not
work on a standard cygwin installation; it fails while linking firefox.exe.

The linker cannot find "-lUrlmon," since  MinGW currently does not provide the
"Urlmon" library (see http://cvs.sourceforge.net/viewcvs.py/mingw/w32api/lib/).

This problem can be fixed easily by removing "Urlmon" from STATIC_EXTRA_LIBS in
config/static-config.mk.  It seems that this library is not used at all (I am
using --disable-accessibility and --disable-activex).
(Reporter)

Comment 1

14 years ago
Created attachment 169667 [details] [diff] [review]

removing "Urlmon" from statically linking

removing "Urlmon" from statically linking

enables static builds on cygwin
(Reporter)

Comment 2

14 years ago
Is the "Urlmon" library used when building with MSVC?  If not, we could remove
it generally.  Maybe also #include <urlmon.h> could be removed.

Comment 3

14 years ago
Hans-Andreas, you're going to have to answer those kinds of questions before I
can review this, or find somebody who can.
(Reporter)

Comment 4

14 years ago
I am not asking for a review on this patch.  (I only described a problem, the
reason why it appears, and how it could be fixed on cygwin.)

Benjamin, I thought you might be interested in this issue and added you as CC;
sorry if this caused a misunderstanding.

Indeed, I would like to find someone who has MSVC (I don't) and could try if
linking firefox/mozilla without the "Urlmon" library works.  Otherwise, this
library can only be removed for cygwin, i.e., a more sophisticated patch to
static-config.mk is required.

Updated

13 years ago
Assignee: bryner → nobody
Component: Build Config → Build Config
Product: Firefox → Core
QA Contact: asa → build-config
Summary: static build on cygwin broken (should not link Urlmon) → static build on cygwin/mingw broken (should not link Urlmon)
Version: unspecified → Trunk

Comment 5

13 years ago
Created attachment 201152 [details] [diff] [review]
remove all urlmon references

This patch removes all core urlmon references (except the activex plugin) from the tree.  I tested it with mingw gcc & the free vc71 builds.
Attachment #169667 - Attachment is obsolete: true
Attachment #201152 - Flags: review?(benjamin)
(Reporter)

Comment 6

13 years ago
Great!  Chris, thank you for fixing this and for testing.

Updated

13 years ago
Attachment #201152 - Flags: review?(benjamin) → review+

Updated

13 years ago
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha

Updated

2 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.