Open Bug 276163 Opened 20 years ago Updated 2 years ago

extern incongruities in NSS headers

Categories

(NSS :: Libraries, defect, P4)

Product:
NSS
Component:
Libraries
Version:
3.9.3
Platform:
x86
Linux
Type:
defect

Tracking

(Not tracked)

People

(Reporter: jason.m.reid, Unassigned)

Details

security/nss/lib/nss/nss.h is incongrous in its use of extern. This
can confuse a human reader of the header files.
NSS_VersionCheck, NSS_Init, NSS_IsInitialized,NSS_InitReadWrite, NSS_Initialize,
and NSS_Shutdown are defined with extern in the header file. NSS_NoDB_Init,
PK11_ConfigurePKCS11, and nss_DumpCertificateCacheInfo are not.
Jason, thanks for reporting this.

This is a known issue and is not limited to nss.h.

I believe (by reading section A10.2 of
The C Programming Language, 2nd Ed.) that the extern
keyword in header files is optional (as long as 'static'
is not specified, the identifier has external linkage).
So this is just a matter of style.  If you agree, do we
prefer using extern explicitly?
Summary: extern incongruities in nss.h → extern incongruities in NSS headers
QA Contact: bishakhabanerjee → jason.m.reid
Assignee: wtchang → nobody
QA Contact: jason.m.reid → libraries
Priority: -- → P4
Severity: trivial → S4
You need to log in before you can comment on or make changes to this bug.