276190 - Moving node with binding between documents is broken

Status: RESOLVED WONTFIX

(Core :: XBL, defect)

Description

[alexander :surkov (:asurkov)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041122
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041122

I create node with binding in first document, clone it and attach into second
document. I dont include styles into second document where -moz-binding is
defined. In this case binding has all properties and methods, has content, but
bindings for content is not defined.

Reproducible: Always

Steps to Reproduce:
//bindings.xml

<bindings id="testBindings"
	xmlns="http://www.mozilla.org/xbl"
	xmlns:xul="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"

<binding id="binding1">
<content>
  <xul:textbox/>
</content>
</binding>

</bindings>

//bindings.css
binding1{
  -moz-binding: url('bindings.xml#binding1');
}

//firstdoc.xul

<window xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">

<binding1 id="bnd"/>

<script>
var node=document.getElementById('bnd');
openDialog('seconddoc.xul', 'helo', '', node);
</script>

</window>

//seconddoc.xul

<window xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">

<script>
var node=window.arguments[0];
var newnode=node.clone(node);
document.getElementById('container').appendChild(newnode);
</script>

<box id="container"/>

</window>
Actual Results:  
textbox of binding content has not bindings

Expected Results:  
textbox of binding shuld have bindings

Comment 1

[alexander :surkov (:asurkov)]

Attachment: bindings

Comment 2

[alexander :surkov (:asurkov)]

Attachment: -moz-binding

Comment 3

[alexander :surkov (:asurkov)]

Attachment: second document

Comment 4

[alexander :surkov (:asurkov)]

Attachment: first document (run it)

Make package and run firstdoc.xul file. Content of attached node into second
document has not bindings. See by DOM Inspector.

Comment 5

[alexander :surkov (:asurkov)]

If I don't clone the node and I attach it to second document then I get the next
situation. If I don't include styles with -moz-binding into second document then
node isn't displayed. If I include thease styles then I node is displayed.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: CSS pointing to bindings

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Second document modified to not need openDialog

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: Ignore this one.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: First document, modified to point to second. LOAD THIS.

Comment 10

[Boris Zbarsky [:bzbarsky]]

So the problem here is that when we clone the node we attach a binding to it
based on its ownerDocument.  Then when we insert the node into our new document,
we call nsBindingManager::ChangeDocumentFor on the node.  This sets the same
binding in the binding manager of the new document (why?) and messes around with
the anonymous content; specifically it sets the document on all the anonymous
content to null.  As a result, styles don't apply to it (it's not in a
document), so we don't apply xul.css, hence no rendering.

So what is ChangeDocumentFor really trying to accomplish?  If it's trying to
kill off the binding, why is it transferring it to the new document?  If it's
trying to keep the binding alive, why is it setting the document on all
anonymous content to null?

Comment 11

[Boris Zbarsky [:bzbarsky]]

XBL is now disabled in Firefox (Bug 1583314) and is in the process of being removed from Gecko (Bug 1566221), so closing bugs requesting changes to its implementation as wontfix.