277089 - tinderbox panel output should be sorted by build start, not build end

Status: RESOLVED FIXED

Description

[David Baron :dbaron: ⌚️UTC-7]

The tinderbox panel output is currently sorted in reverse order by build end. 
This isn't all that useful for telling how things are changing.  I think it
would be more useful for it to be sorted by build start -- this allows one to
tell if things are turning orange or turning green much more easily.

Patch to follow, except I can't test it.  The patch also makes the static
version link to the static full page (no change), and the dynamic one link to
the dynamic full page (change).

Anybody have a tinderbox server this could be tested on?

Comment 1

[David Baron :dbaron: ⌚️UTC-7]

Created attachment 170321 [details] [diff] [review]
patch

Comment 2

[David Baron :dbaron: ⌚️UTC-7]

Created attachment 170322 [details] [diff] [review]
patch

Comment 3

[timeless]

Comment on attachment 170322 [details] [diff] [review]
patch

+    print "http://tinderbox.mozilla.org/$::tree/";
+  } else {
+    print "http://tinderbox.mozilla.org/showbuilds.cgi?tree=$::tree";

please make that "/$::tree/" and "/showbuilds.cgi?tree=$::tree"
if i did have a tinderbox1 handy, those items wouldn't work because they're
hard coded :(

Comment 4

[David Baron :dbaron: ⌚️UTC-7]

Created attachment 170347 [details] [diff] [review]
patch

This makes them even more relative than suggested.

Comment 5

[David Baron :dbaron: ⌚️UTC-7]

Landed tbglobals.pl comment change; still need to test showbuilds.cgi change.

Comment 6

[Chase Phillips]

When you have it, please offer a link to an example of this change in action.

Comment 7

[David Baron :dbaron: ⌚️UTC-7]

Checked in, since this was tested on the live instance (bug 333778).