277301 - webdav extension has undefined reference to `gDAVLog' in non-debug builds

Status: RESOLVED WORKSFORME

(Core Graveyard :: WebDAV, defect)

Description

[Mostafa Hosseini]

Non debug build of webdav yields:

nsWebDAVService.o: In function
`nsWebDAVService::SendDocumentToChannel(nsIDocument*, nsIHttpChannel*, char
const*, nsIStreamListener*, int)':
nsWebDAVService.o(.text+0x3e5): undefined reference to `gDAVLog'
nsWebDAVService.o(.text+0x4c4): undefined reference to `gDAVLog'
nsWebDAVService.o(.text+0x77b): undefined reference to `gDAVLog'
nsWebDAVService.o: In function `nsWebDAVService::nsWebDAVService[not-in-charge]()':
nsWebDAVService.o(.text+0xe20): undefined reference to `gDAVLog'
nsWebDAVService.o: In function `nsWebDAVService::nsWebDAVService[in-charge]()':
nsWebDAVService.o(.text+0xecc): undefined reference to `gDAVLog'

because due to 
http://lxr.mozilla.org/mozilla/source/extensions/webdav/src/nsWebDAVUtils.cpp#51

gDAVLog is not defined.

Comment 1

[Mike Shaver (:shaver emeritus)]

I'm not quite sure what the issue is here -- I thought we fixed this before, and
it looks like all references to gDAVLog are protected by the same PR_LOGGING
check that controls the symbol definition.  Are all the objects being built with
the same opt/debug flags?

(We should really just force NSPR logging on for this component anyway.)

Comment 2

[Mike Shaver (:shaver emeritus)]

I can't reproduce this in my piles of builds, so...WFM?