Closed Bug 277342 Opened 20 years ago Closed 19 years ago

JS Console behaving incorrectly with right-click on source file

Categories

(Core Graveyard :: Error Console, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: csthomas, Unassigned)

References

()

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

Error: Selector expected.  Ruleset ignored due to bad selector.
Source File: http://www.google.com/
Line: 5

Right-clicking "http://www.google.com" immediately brings up the source, instead
of a context menu.
I see this in my 1/03 and 1/06 builds.
Worksforme in a current Linux trunk build (01/06).  Is this Windows-only?  Is
this a regression?
Though note that the console uses <handler event="click"> and doesn't filter on
the button.  Could that be a problem?
An explicit button filter would be the easiest fix (the other way would involve
changing the binding to extend xul:button to be able to use a command handler).
OK.  So in consoleBindings.xml, the event handler for click should check that
it's the left button being clicked (event.button == 0).
Whiteboard: [good first bug]
Actually, XBL should do the check, not the event handler.
What's the XBL syntax for that?
not windows only - also seen on linux/gtk2/trunk/Do Jan 6 21:30:17 CET 2005

as for the button check, use a button attribute (like at
http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/bindings/radio.xml#410
)
OS: Windows XP → All
*** Bug 120287 has been marked as a duplicate of this bug. ***
*** Bug 220617 has been marked as a duplicate of this bug. ***
Attached patch PatchSplinter Review
What biesi said in the form of a patch. I tested this (only on Linux) and it
fixes the bug. The context menu items still work and the view-source window is
only opened on left click now.
Attachment #172912 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #172912 - Flags: review?(mconnor)
Attachment #172912 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Attachment #172912 - Flags: review?(mconnor) → review+
Fix checked in.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Core → SeaMonkey
Product: SeaMonkey → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: