277342 - JS Console behaving incorrectly with right-click on source file

Status: RESOLVED FIXED

(Core Graveyard :: Error Console, defect)

Description

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Error: Selector expected.  Ruleset ignored due to bad selector.
Source File: http://www.google.com/
Line: 5

Right-clicking "http://www.google.com" immediately brings up the source, instead
of a context menu.

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

I see this in my 1/03 and 1/06 builds.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Worksforme in a current Linux trunk build (01/06).  Is this Windows-only?  Is
this a regression?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Though note that the console uses <handler event="click"> and doesn't filter on
the button.  Could that be a problem?

Comment 4

[[e-mail]]

An explicit button filter would be the easiest fix (the other way would involve
changing the binding to extend xul:button to be able to use a command handler).

Comment 5

[Boris Zbarsky [:bzbarsky]]

OK.  So in consoleBindings.xml, the event handler for click should check that
it's the left button being clicked (event.button == 0).

Comment 6

[[e-mail]]

Actually, XBL should do the check, not the event handler.

Comment 7

[Boris Zbarsky [:bzbarsky]]

What's the XBL syntax for that?

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

not windows only - also seen on linux/gtk2/trunk/Do Jan 6 21:30:17 CET 2005

as for the button check, use a button attribute (like at
http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/bindings/radio.xml#410
)

Comment 9

[Boris Zbarsky [:bzbarsky]]

*** Bug 120287 has been marked as a duplicate of this bug. ***

Comment 10

[Boris Zbarsky [:bzbarsky]]

*** Bug 220617 has been marked as a duplicate of this bug. ***

Comment 11

[Stefan Borggraefe]

Attachment: Patch

What biesi said in the form of a patch. I tested this (only on Linux) and it
fixes the bug. The context menu items still work and the view-source window is
only opened on left click now.

Comment 12

[Stefan Borggraefe]

Fix checked in.