277377 - Classifications should support sort keys

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[timeless]

i believe this is a blocker to implementing classifications on bmo.

i'm told that the classifications code lists classifications in alphabetical
order, which just won't do for bmo :).

Comment 1

[Dave Miller [:justdave]]

Reassigning bugs that I'm not actively working on to the default component owner
in order to try to make some sanity out of my personal buglist.  This doesn't
mean the bug isn't being dealt with, just that I'm not the one doing it.  If you
are dealing with this bug, please assign it to yourself.

Comment 2

[Olav Vitters]

Wanted for bgo

Comment 3

[Olav Vitters]

Attachment: Patch v1

Comment 4

[Olav Vitters]

Attachment: Patch v1.1

<mkanat> bkor: checksetup should print out a message about what it's doing.
<mkanat> bkor: Just one message.
<bkor> mkanat: ok
<bkor> are you reviewing the whole patch?
<mkanat> bkor: No, I'm not reviewing the whole patch.

Comment 5

[Frédéric Buclin]

Comment on attachment 228493 [details] [diff] [review]
Patch v1.1

>Index: Bugzilla/DB/Schema.pm

>+            sortkey     => {TYPE => 'INT2', NOTNULL => 1, DEFAULT => 0},

Should be '0' (with quotes). Else works fine. r=LpSolit

Note: there is some bitrot in checksetup.pl. I will attach an unbitrotten patch.

Comment 6

[Frédéric Buclin]

Attachment: unbitrotten patch, v1.1

Comment 7

[Frédéric Buclin]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.506; previous revision: 1.505
done
Checking in editclassifications.cgi;
/cvsroot/mozilla/webtools/bugzilla/editclassifications.cgi,v  <--  editclassifications.cgi
new revision: 1.24; previous revision: 1.23
done
Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v  <--  enter_bug.cgi
new revision: 1.142; previous revision: 1.141
done
Checking in Bugzilla/Classification.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Classification.pm,v  <--  Classification.pm
new revision: 1.10; previous revision: 1.9
done
Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.118; previous revision: 1.117
done
Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.54; previous revision: 1.53
done
Checking in template/en/default/admin/classifications/add.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/classifications/add.html.tmpl,v  <--  add.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/admin/classifications/del.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/classifications/del.html.tmpl,v  <--  del.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/admin/classifications/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/classifications/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.8; previous revision: 1.7
done
Checking in template/en/default/admin/classifications/reclassify.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/classifications/reclassify.html.tmpl,v  <--  reclassify.html.tmpl
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/admin/classifications/select.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/classifications/select.html.tmpl,v  <--  select.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/admin/classifications/update.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/classifications/update.html.tmpl,v  <--  update.html.tmpl
new revision: 1.2; previous revision: 1.1
done

Comment 8

[Max Kanat-Alexander]

checksetup.pl was printing out twice that it added the column, because of an unnecessary print that I just removed (r=LpSolit, a=justave):

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.507; previous revision: 1.506
done

Comment 9

[Max Kanat-Alexander]

Added to the relnotes currently attached to bug 349423.