Closed
Bug 277638
Opened 20 years ago
Closed 20 years ago
Instance is not null checked [@XPCConvert::JSErrorToXPCException]
Categories
(Core :: XPConnect, defect)
Tracking
()
VERIFIED
DUPLICATE
of bug 288532
People
(Reporter: dewildt, Assigned: dewildt)
References
()
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
|
1.53 KB,
patch
|
shaver
:
review+
|
Details | Diff | Splinter Review |
In "data = new nsScriptError();" is "data" not checked for null which will
happen in OOM situations. No TB data available.
http://lxr.mozilla.org/seamonkey/source/js/src/xpconnect/src/xpcconvert.cpp#1391
> data = new nsScriptError();
> NS_ADDREF(data);
> data->Init(bestMessage.get(),
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•20 years ago
|
Assignee: dbradley → mozilla3q04
Status: ASSIGNED → NEW
|
|
Assignee | |
Comment 1•20 years ago
|
||
Create an error without details if it fails to alloc memory for nsScriptError
Attachment #172279 -
Flags: review?(shaver)
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 2•20 years ago
|
||
Comment on attachment 172279 [details] [diff] [review]
Patch
I personally tend to think we should return NS_ERROR_OUT_OF_MEMORY, but I guess
best-effort isn't a bad policy for error reporting. dbradley: break the tie?
Attachment #172279 -
Flags: superreview?(dbradley)
Attachment #172279 -
Flags: review?(shaver)
Attachment #172279 -
Flags: review+
|
|
Assignee | |
Comment 3•20 years ago
|
||
*** This bug has been marked as a duplicate of 288532 ***
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
|
|
Assignee | |
Comment 4•20 years ago
|
||
Comment on attachment 172279 [details] [diff] [review]
Patch
Remove flag request
Attachment #172279 -
Flags: superreview?(dbradley)
|
||
Updated•14 years ago
|
Crash Signature: [@XPCConvert::JSErrorToXPCException]
You need to log in
before you can comment on or make changes to this bug.
Description
•