277664 - e4x: XML 1.0 Well-formedness constraint: Unique Att Spec not implemented

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Martin Honnen]

The XML 1.0 specification at:
<http://www.w3.org/TR/2004/REC-xml-20040204/#sec-starttags>
says:
  "An attribute name MUST NOT appear more than once in the same start-tag or
empty-element tag."
however Spidermonkey currently (at least when tested with a recent Mozilla 1.8a
nightly with script inside <script type="text/javascript; e4x=1>) parses XML alike
  var god = <god name="Kibo" name="Xibo" />;
without throwing an error.
Rhino gives an error however:
  "error: Attribute "name" was already specified for element "god"."
I think Spidermonkey needs to test that well-formedness constraint too and throw
an error. Currently it indeed seems to have two attributes with the same name
e.g. xml.attributes().length() yields 2, toXMLString then yields markup with
other XML parsers would throw a well-formedness error on.
JavaScript test case is here:
<http://home.arcor.de/martin.honnen/mozillaBugs/e4x/attributeNameDuplicated.js>
HTML test case using that script is here:
<http://home.arcor.de/martin.honnen/mozillaBugs/e4x/attributeNameDuplicated.html>

Comment 1

[Brendan Eich [:brendan]]

Attachment: fix

I also shortened ATTRIBUTE to ATTR uniformly in js.msg.

/be

Comment 2

[Mike Shaver (:shaver emeritus)]

Comment on attachment 170858 [details] [diff] [review]
fix

r=shaver

Comment 3

[Brendan Eich [:brendan]]

Fixed, thanks^2.

/be

Comment 4

[Martin Honnen]

Verified fixed with Mozilla 1.8b (Mozilla/5.0 (Windows; U; Windows NT 5.1;
en-US; rv:1.8b) Gecko/20050122)

Comment 5

[Bob Clary [:bc] (inactive)]

Attachment: e4x/Regress/regress-277664.js

Martin, with your permission this will be included in the javascript test
library.

Comment 6

[Bob Clary [:bc] (inactive)]

e4x/Regress/regress-277664.js checked in.