Closed
Bug 277839
Opened 20 years ago
Closed 19 years ago
Implement /notice command
Categories
(Other Applications :: ChatZilla, enhancement)
Other Applications
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: O_RenyReny, Assigned: rginda)
Details
(Whiteboard: [cz-0.9.68])
Attachments
(1 file, 1 obsolete file)
6.81 KB,
patch
|
samuel
:
review+
|
Details | Diff | Splinter Review |
The /notice should echo back and show you the messege that was sent, similarly to the /msg command. As of now, there is no reminder or notification that you sent the /notice.
Comment 1•20 years ago
|
||
/notice does not exist. What you really want is to get /notice implemented.
Severity: minor → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: /notice Does Not echo back → Implement /notice command
Reporter | ||
Comment 2•20 years ago
|
||
(In reply to comment #1) > /notice does not exist. What you really want is to get /notice implemented. Heh, oops. I assumed since I've never had trouble in using it in any of the servers I'm on it was a standard command. My mistake.
Comment 3•19 years ago
|
||
I figured this could be done the same way /msg is handled, and I turned out to be right, it seems. I removed all the second parameters to .say, which were redundant. They were there because rginda didn't remove them when switching all text encoding handling to the irc library. (the calls used to be like: user.say(fromUnicode(msg, e.sourceObject)) ) requesting review from Samuel Sieb :-)
Attachment #176045 -
Flags: review?(samuel)
Comment 4•19 years ago
|
||
Comment on attachment 176045 [details] [diff] [review] Patch based on cmdMsg in the .properties file in the line: cmd.notice.help = Sends a notice <msg> to <nickname> <msg> should be <message> to match the params
Attachment #176045 -
Flags: review?(samuel) → review+
Comment 5•19 years ago
|
||
Updated both the help messages of /notice and of /msg, since both had <msg> instead of <message>.
Attachment #176045 -
Attachment is obsolete: true
Attachment #176057 -
Flags: review?(samuel)
Updated•19 years ago
|
Attachment #176057 -
Flags: review?(samuel) → review+
Comment 6•19 years ago
|
||
Checked in --> FIXED. In approximately 41 minutes a build with this fix will be available from: http://twpol.dyndns.org/mozilla/chatzilla/nightly/
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•19 years ago
|
Whiteboard: [cz-0.9.68]
You need to log in
before you can comment on or make changes to this bug.
Description
•