[FIXr]Crash if <property> has no name attribute [@ nsXBLProtoImplProperty::nsXBLProtoImplProperty()]

VERIFIED FIXED in mozilla1.8beta1

Status

()

P2
critical
VERIFIED FIXED
14 years ago
10 years ago

People

(Reporter: stefanh, Assigned: bzbarsky)

Tracking

({crash, testcase})

Trunk
mozilla1.8beta1
crash, testcase
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(3 attachments)

(Reporter)

Description

14 years ago
Mozilla 2005010905, Mac OS X.

I seem to crash if I leave out the name attribute in the property element.
Testcase is on the way...
(Reporter)

Comment 1

14 years ago
Created attachment 170935 [details]
Testcase

Hmm, looks like Talkback isn't included in the mac nightlies anymore? Will
attach a OS X crash log. I do have TB3002288K from the same crash with Firefox
1.0, though.
(Reporter)

Comment 2

14 years ago
Created attachment 170936 [details]
Crash log
(Reporter)

Comment 3

14 years ago
Here's the source of the testcase file:

<?xml version="1.0"?>
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>Testcase</title>
<xbl:bindings xmlns="http://www.mozilla.org/xbl"
  xmlns:xbl="http://www.mozilla.org/xbl">
  <binding id="test">
    <implementation>
      <property/>
    </implementation>
  </binding>
</xbl:bindings>
<style type="text/css">
  p{ -moz-binding: url(#test); }
</style>
</head>
<body>
<p></p>
</body>
</html>

Add 'name="foo"' to property and you will not crash.
Keywords: crash, testcase
(Assignee)

Comment 4

14 years ago
Created attachment 170975 [details] [diff] [review]
Just needs a null-check....
Assignee: hyatt → bzbarsky
Status: NEW → ASSIGNED
Attachment #170975 - Flags: superreview?(bryner)
Attachment #170975 - Flags: review?(bryner)
(Assignee)

Updated

14 years ago
OS: MacOS X → All
Priority: -- → P2
Hardware: Macintosh → All
Summary: Crash if <property> has no name attribute [@ nsXBLProtoImplProperty::nsXBLProtoImplProperty()] → [FIX]Crash if <property> has no name attribute [@ nsXBLProtoImplProperty::nsXBLProtoImplProperty()]
Target Milestone: --- → mozilla1.8beta
Attachment #170975 - Flags: superreview?(bryner)
Attachment #170975 - Flags: superreview+
Attachment #170975 - Flags: review?(bryner)
Attachment #170975 - Flags: review+
(Assignee)

Updated

14 years ago
Summary: [FIX]Crash if <property> has no name attribute [@ nsXBLProtoImplProperty::nsXBLProtoImplProperty()] → [FIXr]Crash if <property> has no name attribute [@ nsXBLProtoImplProperty::nsXBLProtoImplProperty()]
(Assignee)

Comment 5

14 years ago
Fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

14 years ago
v
Status: RESOLVED → VERIFIED

Comment 7

10 years ago
content/xbl/crashtests/277950-1.xhtml
http://hg.mozilla.org/mozilla-central/rev/b0337b6287f3
Flags: in-testsuite+
Crash Signature: [@ nsXBLProtoImplProperty::nsXBLProtoImplProperty()]
You need to log in before you can comment on or make changes to this bug.