Closed Bug 278171 Opened 20 years ago Closed 16 years ago

r:/mozilla\xpcom\obsolete\nsFileSpecImpl.cpp(730) : warning C4244: '=' : conversion from 'PRInt64' to 'PRInt32', possible loss of data

Categories

(Core :: XPCOM, defect)

defect
Not set
critical

Tracking

()

VERIFIED DUPLICATE of bug 450359

People

(Reporter: timeless, Unassigned)

References

()

Details

(Keywords: dataloss)

r:/mozilla\xpcom\obsolete\nsFileSpecImpl.cpp(730) : warning C4244: '=' :
conversion from 'PRInt64' to 'PRInt32', possible loss of data

I think the code should be changed to only assign the low portion of the PRInt64
to the result IFF the high portion is 0.

otherwise, return NS_ERROR_FILE_TOO_BIG.
After some discussion, I'm no longer clear on whether this is a WONTFIX or which
solution to use (change the retval type, or limit to 32 bits).
Assignee: cst → dougt
Assignee: dougt → nobody
QA Contact: xpcom
Severity: minor → critical
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: helpwanteddataloss
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → DUPLICATE
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.