278596 - View / Message Body As in messenger broken

Status: RESOLVED FIXED

(MailNews Core :: MIME, defect)

Description

[Mikael Parknert]

After my last check-in for bug 226005, View / Message Body As
in messenger is broken.

The reason for this is that the old mime-code is broken. It is
using a nsIPref*, doing a ->Release() on it, but using it
anyway after that. In the new code checked in I used a nsCOMPtr
instead of a pointer, making calls after it was released to fail.

Comment 1

[Mikael Parknert]

Attachment: regression fix

As suggested by biesi on irc, do not clear out the m_prefBranch.

With this patch, View / Message Body As works. I'm not completely
convinced that m_prefBranch is released at all times, but I did 
not manage to get RefCount balancer to work in my build so I
can't verify this.

I am out of town for a few days so if reviewers approve this patch maybe
I could get some help to check it in.

Comment 2

[[e-mail]]

Comment on attachment 171402 [details] [diff] [review]
regression fix

options contains other nsCOMPtrs and I'm sure they're properly released.

Comment 3

[David :Bienvenu]

Comment on attachment 171402 [details] [diff] [review]
regression fix

since MimeDisplayOptions is now a class instead of a struct, this should be ok,
as long is it gets deleted.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

patch checked in. please resolve the bug if it is fixed now.

Checking in mailnews/mime/src/mimedrft.cpp;
/cvsroot/mozilla/mailnews/mime/src/mimedrft.cpp,v  <--  mimedrft.cpp
new revision: 1.139; previous revision: 1.138
done
Checking in mailnews/mime/src/mimemoz2.cpp;
/cvsroot/mozilla/mailnews/mime/src/mimemoz2.cpp,v  <--  mimemoz2.cpp
new revision: 1.215; previous revision: 1.214
done

Comment 5

[Mikael Parknert]

Works now in build 20050120