278701 - Minimised windows don't indicate that breakpoints have been hit

Status: RESOLVED FIXED

(Rhino Graveyard :: Core, enhancement)

Description

[James Eggleston]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; .NET CLR 1.0.3705)
Build Identifier: rhino1_5R5

The debugger normally brings hidden windows to the front when a breakpoint is 
hit, which informs the user that their script is frozen. 

However, if the window is minimised to the task bar (not simply underneath 
other windows), then the user receives no feedback that their script has hit a 
breakpoint. In our use case, this means that the system is frozen at the 
breakpoint, but the user does not realise this. 

(I guess this is subjective; it could be argued that if the user has minimised 
their window, they don't want any feedback?)


Reproducible: Always

Steps to Reproduce:
1. Attach a debug session to a Rhino engine with any script containing a 
function definition
2. Set a breakpoint in that function
3. Minimise the window
4. Execute the function so that the break point is hit

Actual Results:  
The breakpoint is hit, but the debugger window does not show any feedback. The 
thread of execution never returns to the program that passed the command to the 
Rhino engine. 

Expected Results:  
I would like the debugger window to unminimise itself, or possible start 
flashing on the toolbar, drawing the users attention to it. 

We have altered our version to get the desired behaviour... 

The following code, added to the EnterInterrupt class definition in 
toolsrc/org/mozilla/javascript/tools/debugger/Main.java, does what I'd like to 
see happen (starting with the code at line numbers 1957):

1957: // raise the debugger window
      int state = db.getExtendedState();
      if (state == Frame.ICONIFIED)
      {
         db.setExtendedState(Frame.NORMAL);
      }
1958: db.toFront();

Comment 1

[Igor Bukanov]

Attachment: Implementation as a patch

Comment 2

[Igor Bukanov]

Attachment: Compilable version of the patch

Comment 3

[Igor Bukanov]

I committed the patch