279167 - ASSERTION: HTML elements in an HTML document should have kNamespaceID_None in nsObjectFrame::CreateDefaultFrames

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Frank Wein [:mcsmurf]]

When you surf to a page which needs a plugin, which you don't have installed,
you get the replacement content in Firefox (also the logo there is broken atm,
but i'll address this in another bug). But you also get this assertion:
"###!!! ASSERTION: HTML elements in an HTML document should have kNamespaceID_None
 as their namespace ID.: '!aDocumentDefaultType || IsXHTML() || aNamespaceID == k
NameSpaceID_None', file d:/mozilla/tree6/mozilla/content/html/document/src/nsHTML
Document.cpp, line 4105"
(four times)
I think this should be fixed in nsObjectFrame.cpp, Method
nsObjectFrame::CreateDefaultFrames

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Comment 2

[Frank Wein [:mcsmurf]]

Attachment: Patch

Attached wrong patch before

Comment 3

[Frank Wein [:mcsmurf]]

Comment on attachment 178806 [details] [diff] [review]
Patch

This wouldn't work for all cases...

Comment 4

[Frank Wein [:mcsmurf]]

Comment on attachment 178806 [details] [diff] [review]
Patch

This wouldn't work for all cases...

Comment 5

[Frank Wein [:mcsmurf]]

Attachment: Patch 2

This patch sets kNameSpaceID_None for all HTML documents and kNameSpaceID_XHTML
for everything else.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 179094 [details] [diff] [review]
Patch 2

Looks good, r+sr=jst (but beware that there's a patch on its way in that
changes the div to an anchor tag (<a>), so there may be conflicts, but this is
the right thing to do in both cases.

Comment 7

[Frank Wein [:mcsmurf]]

Attachment: Patch to checkin

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in layout/generic/nsObjectFrame.cpp;
/cvsroot/mozilla/layout/generic/nsObjectFrame.cpp,v  <--  nsObjectFrame.cpp
new revision: 1.495; previous revision: 1.494
done

Comment 9

[[e-mail]]

Comment on attachment 179389 [details] [diff] [review]
Patch to checkin

>+  PRInt32 id;
>+  if (htmldoc && !doc->IsCaseSensitive())
>+    id = kNameSpaceID_None;
>+  else
>+    id = kNameSpaceID_XHTML;
  PRInt32 id = htmldoc && !doc->IsCaseSensitive() ? kNameSpaceID_None :
kNameSpaceID_XHTML;
... is more than 80 columns :-/