Closed Bug 279212 Opened 20 years ago Closed 8 years ago

Tweak print-failed-commands control

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: roc, Assigned: roc)

Details

Attachments

(1 file)

trivial fix
706 bytes, patch
bryner
: review+
bryner
: superreview+
Details | Diff | Splinter Review
rules.mk says: # ELOG prints out failed command when building silently (gmake -s). -ifneq (,$(findstring s,$(MAKEFLAGS))) If you use an extended option to 'make' that happens to contain an 's', this rule fires, but it shouldn't.
Attached patch trivial fix — — Splinter Review
Attachment #171963 - Flags: superreview?(bryner)
Attachment #171963 - Flags: review?(bryner)
Attachment #171963 - Flags: superreview?(bryner)
Attachment #171963 - Flags: superreview+
Attachment #171963 - Flags: review?(bryner)
Attachment #171963 - Flags: review+
QA Contact: build-config
Assignee: roc → nobody
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a769c279e9c4 More robust argument detection for ELOG; r=bryner
Rebased and landed.
Assignee: nobody → roc
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/a769c279e9c4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: