27951 - <INPUT TYPE="RESET"> doesn't clear text field

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[djoham]

From Bug Helper:
User-Agent: Mozilla/4.61 [en] (X11; I; Linux 2.2.12-20 i686)
BuildID:    2000021510
Sometime between the release of M13 and this build, the intput type of RESET
doesn't seems to have been broken.

The test case I'm submitting works as expected on Linux Netscape 4.x as well as
in Linux Mozilla M13. Something must have regressed....
Reproducible: Always
Steps to Reproduce:
1.fill in some text on a form with a reset button
2.click on the reset button 
3.
Actual Results:  nothing happens		
Expected Results:  the text box should be cleared.

Comment 1

[djoham]

Attachment: test case

Comment 2

[Sitsofe Wheeler]

This sounds like a dup of bug 3547. If this is the case, then bug 3547 has
regressed.

Comment 3

[Richard Zach]

Confirmed on Linux build 2000.02.21.08. Reassign to component owner.

Comment 4

[Richard Zach]

Oops. Forgot to check the right box.  Reassigning for real now.

Comment 5

[karnaze (gone)]

Reassigning to Eric.

Comment 6

[Matt Bissiri]

narrowing down the time when this regression was introduced:
this bug does not occur with 2000020509 linux rh6.1
this bug occurs with 2000020708 linux rh6.1

Comment 7

[Matt Bissiri]

This bug only occurs if the text input has value="" or value attr not given:
<input type=text value=""> or <input type=text>

This bug does not occur if the text input has non-empty value attr, for example:
<input type=text value="1234">

Comment 8

[Matt Bissiri]

Attachment: new testcase demonstrating my comment above

Comment 9

[Matt Bissiri]

Here is what gdb is showing me:

It looks this bug 27951 was introduced when
editor/base/nsTextEditRules.cpp rev 1.97 landed.
nsTextEditRules needs to be modified to correct this.

in layout/html/forms/src/nsGfxTextControlFrame.cpp:
The nsGfxTextControlFrame calls this function:
htmlEditor->InsertText(aValue);
when aValue == "" nothing happens, and when aValue != "" it works fine.

in editor/base/nsHTMLEditor.cpp:
inside nsHTMLEditor::InsertText(), this function is called:
result = mRules->WillDoAction(selection, &ruleInfo, &cancel, &handled);

nsTextEditRules::WillDoAction
then calls:
nsTextEditRules::WillInsertText

Take a look at this code, it shows why this problem is happening:
http://lxr.mozilla.org/seamonkey/source/editor/base/nsTextEditRules.cpp#505

Comment 10

[Matt Bissiri]

Adding jfrancis to cc-list,
he committed editor/base/nsTextEditRules.cpp rev 1.97

Comment 11

[Eric Pollmann]

Thanks Matt for excellent work debugging this one!

 I'm going to hand it off to [e-mail] to find an alternate hack for
IME or setting a text field to "".  Also CC'ing buster, the GfxTextControlFrame
guru.

Comment 12

[Joe Francis]

You should not need to ever call InsertText() with an empty string.  What are you 
trying to do?  If you are trying to clear the string this is not the way to do 
it.

Comment 13

[Joe Francis]

handing back to pollmann to make sure i find out what's up...

Comment 14

[Eric Pollmann]

Yes, it appears that the code in nsGfxTextControlFrame is trying to set the text
of the input using the InsertText call.  What is the correct call to make here?

Buster might have more information on this.  The code in question is 
 nsGfxTextControlFrame::SetTextControlFrameState() around line 1372.  It appears
to be trying to set the complete contents of the editor.

Handing it back to jfrancis for an answer.  (Feel free to bounce it back to me) 
This bug is a hot potato!  :)

Comment 15

[Joe Francis]

ok - i'm looking into this...

Comment 16

[Joe Francis]

In nsGfxTextControlFrame::SetTextControlFrameState(), try making these changes:


      // get the flags, remove readonly and disabled, set the value, restore 
flags
      PRUint32 flags, savedFlags;
      mEditor->GetFlags(&savedFlags);
      flags = savedFlags;
      flags &= ~(nsIHTMLEditor::eEditorDisabledMask);
      flags &= ~(nsIHTMLEditor::eEditorReadonlyMask);
      mEditor->SetFlags(flags);
+     mEditor->SelectAll();
+     mEditor->DeleteSelection(nsIEditor::eNone);
      htmlEditor->InsertText(aValue);
      mEditor->SetFlags(savedFlags);

Note that the lines with the "+" are new (and don't include the +, obviously).
SelectAll(), then DeleteSelection() is the right way to clear out the string.

back to pollmann....

Comment 17

[Eric Pollmann]

*** Bug 30458 has been marked as a duplicate of this bug. ***

Comment 18

[Sitsofe Wheeler]

I think they may also happen if the input type is file... Enclosing attachment.

Comment 19

[Sitsofe Wheeler]

I think they may also happen if the input type is file... Enclosing attachment.

Comment 20

[Sitsofe Wheeler]

Attachment: Input testcase type=file

Comment 21

[Eric Pollmann]

Yes, this is happening with text inputs, text areas, and password, and file
inputs.  The fix that jfrancis proposed takes care of this bug.  I'll check it
in when the tree opens for general checkins.  Thanks!

Comment 22

[Eric Pollmann]

*** Bug 31329 has been marked as a duplicate of this bug. ***

Comment 23

[Eric Pollmann]

I just checked in jfracis's fix.



To verify this fix, go to the above testcases.  Clicking on Reset should clear

the inputs for all of them.  Thanks!

Comment 24

[Eric Pollmann]

*** Bug 27835 has been marked as a duplicate of this bug. ***

Comment 25

[bsharma]

Updating QA contact.

Comment 26

[Madhur Bhatia]

verified fixed - buildID : 2001-08-06-09trunk