Closed Bug 279533 Opened 20 years ago Closed 20 years ago

Update Camino's font preferences code per bug 95227 (serif/sans-serif set is now per language) / serif / sans-serif pref ui doesn't work

Categories

(Camino Graveyard :: Preferences, defect)

PowerPC
macOS
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
Camino0.9

People

(Reporter: masayuki, Assigned: asaf)

References

Details

(Keywords: intl)

Attachments

(1 file)

Currently, bug 95227 is fixed. The default font option(that is sans-serif vs serif) is separated by langGroup. Therefore, the preference dialog of Camino needs change for bug 95227.
In CJK, the font setting is impossible by preferences.
Depends on: 175651
Yes, as it stands now, Camino's serif vs. sans-serif radio buttons do nothing (aside from changing the old pref). We should rewrite these to use the new font.default.<language> preferences.
Severity: normal → major
Summary: Need fix font preferences for bug 95227 → Need fix font preferences for bug 95227 (serif / sans-serif pref ui doesn't work)
Assignee: pinkerton → bugs.mano
Summary: Need fix font preferences for bug 95227 (serif / sans-serif pref ui doesn't work) → Update Camino's font preferences code per bug 95227 (serif/sans-serif set is now per language) / serif / sans-serif pref ui doesn't work
Target Milestone: --- → Camino0.9
Status: NEW → ASSIGNED
Depends on: 95227
Attached patch patch v1Splinter Review
Attachment #174475 - Flags: superreview?(pinkerton)
Attachment #174475 - Flags: review?(joshmoz)
Attachment #174475 - Flags: review?(qa-mozilla)
Attachment #174475 - Flags: review?(qa-mozilla) → review?(mozilla)
Comment on attachment 174475 [details] [diff] [review] patch v1 Looks good to me, aside from the two comment misspellings I pointed out on IRC. I'm not seeing any glaring errors.
Attachment #174475 - Flags: review?(mozilla) → review+
Attachment #174475 - Flags: superreview?(pinkerton) → superreview+
Attachment #174475 - Flags: review?(joshmoz)
Checking in Appearance.h; /cvsroot/mozilla/camino/PreferencePanes/Appearance/Appearance.h,v <-- Appearance.h new revision: 1.8; previous revision: 1.7 done Checking in Appearance.mm; /cvsroot/mozilla/camino/PreferencePanes/Appearance/Appearance.mm,v <-- Appearance.mm new revision: 1.11; previous revision: 1.10 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: