279533 - Update Camino's font preferences code per bug 95227 (serif/sans-serif set is now per language) / serif / sans-serif pref ui doesn't work

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Currently, bug 95227 is fixed.
The default font option(that is sans-serif vs serif) is separated by langGroup.
Therefore, the preference dialog of Camino needs change for bug 95227.

Comment 1

[Hiro]

In CJK, the font setting is impossible by preferences. 

Comment 2

[Wevah (Nate Weaver)]

Yes, as it stands now, Camino's serif vs. sans-serif radio buttons do nothing
(aside from changing the old pref). We should rewrite these to use the new
font.default.<language> preferences.

Comment 3

[Asaf Romano (gone)]

Attachment: patch v1

Comment 4

[Wevah (Nate Weaver)]

Comment on attachment 174475 [details] [diff] [review]
patch v1

Looks good to me, aside from the two comment misspellings I pointed out on IRC.
I'm not seeing any glaring errors.

Comment 5

[Asaf Romano (gone)]

Checking in Appearance.h;
/cvsroot/mozilla/camino/PreferencePanes/Appearance/Appearance.h,v  <--  Appearance.h
new revision: 1.8; previous revision: 1.7
done
Checking in Appearance.mm;
/cvsroot/mozilla/camino/PreferencePanes/Appearance/Appearance.mm,v  <-- 
Appearance.mm
new revision: 1.11; previous revision: 1.10
done