Update Camino's font preferences code per bug 95227 (serif/sans-serif set is now per language) / serif / sans-serif pref ui doesn't work

RESOLVED FIXED in Camino0.9

Status

Camino Graveyard
Preferences
--
major
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: masayuki, Assigned: mano)

Tracking

({intl})

unspecified
Camino0.9
PowerPC
Mac OS X
Dependency tree / graph

Details

Attachments

(1 attachment)

Currently, bug 95227 is fixed.
The default font option(that is sans-serif vs serif) is separated by langGroup.
Therefore, the preference dialog of Camino needs change for bug 95227.

Comment 1

13 years ago
In CJK, the font setting is impossible by preferences. 
Depends on: 175651

Comment 2

13 years ago
Yes, as it stands now, Camino's serif vs. sans-serif radio buttons do nothing
(aside from changing the old pref). We should rewrite these to use the new
font.default.<language> preferences.
Severity: normal → major
Summary: Need fix font preferences for bug 95227 → Need fix font preferences for bug 95227 (serif / sans-serif pref ui doesn't work)
Assignee: pinkerton → bugs.mano
Summary: Need fix font preferences for bug 95227 (serif / sans-serif pref ui doesn't work) → Update Camino's font preferences code per bug 95227 (serif/sans-serif set is now per language) / serif / sans-serif pref ui doesn't work
Target Milestone: --- → Camino0.9
Status: NEW → ASSIGNED
Depends on: 95227
Created attachment 174475 [details] [diff] [review]
patch v1
Attachment #174475 - Flags: superreview?(pinkerton)
Attachment #174475 - Flags: review?(joshmoz)
Attachment #174475 - Flags: review?(qa-mozilla) → review?(mozilla)

Comment 4

13 years ago
Comment on attachment 174475 [details] [diff] [review]
patch v1

Looks good to me, aside from the two comment misspellings I pointed out on IRC.
I'm not seeing any glaring errors.
Attachment #174475 - Flags: review?(mozilla) → review+

Updated

13 years ago
Attachment #174475 - Flags: superreview?(pinkerton) → superreview+
Checking in Appearance.h;
/cvsroot/mozilla/camino/PreferencePanes/Appearance/Appearance.h,v  <--  Appearance.h
new revision: 1.8; previous revision: 1.7
done
Checking in Appearance.mm;
/cvsroot/mozilla/camino/PreferencePanes/Appearance/Appearance.mm,v  <-- 
Appearance.mm
new revision: 1.11; previous revision: 1.10
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.