279738 - Move GetLongDescriptionAsText out of globals.pl

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, enhancement)

Description

[Max Kanat-Alexander]

Really, this should be something like get_comments_for_bug_during_period, and
it's only used by BugMail.pm. It does seem like something that should be in
Bug.pm, though. I'm not sure... any comments?

Comment 1

[Albert Ting]

FYI, I've moved this into BugMail.pm as part of bug #116863

Comment 2

[Max Kanat-Alexander]

OK. One day we need to make that function not suck, but that will probably
happen when we templatize email.

Comment 3

[Frédéric Buclin]

Move this function separately. Marking this bug as blocking the other one as the
patch in 116863 has been denied review.

Comment 4

[Frédéric Buclin]

The move to BugMail.pm is trivial. Why isn't it done yet?

Comment 5

[Max Kanat-Alexander]

Because nobody's patched it, I'd guess. :-)

Comment 6

[Albert Ting]

(In reply to comment #4)
> The move to BugMail.pm is trivial. Why isn't it done yet?

Yea, I've been tied up getting 2.20 installed at my company (among other things)
and only had time to use the original patch in bug #116863.  When things die
down, I can look into breaking it up. Or somebody else could do it.

My only request is that there should still be a "get_all_comments" routine,
which I believe would be needed for bug #116863
 

Comment 7

[Frédéric Buclin]

Let's move it in BugMail.pm for now. As mkanat said, it's only used in
BugMail.pm and moving this routine in Bug.pm would create a module dependency
loop between BugMail.pm and Bug.pm.

Comment 8

[Frédéric Buclin]

Attachment: patch, v1

I'm sure mkanat wants to review this one. After all, you are the one who opened
this bug. :-p

Note that GetLongDescriptionAsText() has been renamed as
BugMail::get_comments_by_bug().

Comment 9

[Max Kanat-Alexander]

Comment on attachment 194173 [details] [diff] [review]
patch, v1

r=mkanat by inspection.

Some day this whole sub needs to die (probably as part of the BugMail re-work
in bug 301447).

Comment 10

[Frédéric Buclin]

Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.336; previous revision: 1.335
done
Checking in Bugzilla/BugMail.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm,v  <--  BugMail.pm
new revision: 1.51; previous revision: 1.50
done