280137 - Get rid of PMWINX dependency

Status: RESOLVED FIXED

(Core Graveyard :: GFX: OS/2, defect)

Description

[Peter Weilbacher]

There seem to be several users out there who for some reason have not installed
PMWINX.DLL on their system (no Open32?) and cannot start Mozilla/Firefox.
Removing the load-time dynamic link from gfx_os2.dll and replacing it with
run-time linking to the registry functions would therefore be a good idea.

Comment 1

[Peter Weilbacher]

Attachment: 1st try to remove pmwinx

PMWINX.DLL actually only forwards the Reg* functions to REGISTRY.DLL, I
therefore load that DLL. The patch also includes Ilya Zakharevich's FPU problem
workaround, although I don't currently know if that is required for this DLL,
too.

It seems to work, but as mentioned in the newsgroup I find it hard to test.
Because even if I move away registry.dll and pmwinx.dll on my system, Mozilla
comes up with anti-aliasing. If I remove them and reboot my system doesn't come
up. Maybe it's too late and I am just too tired to understand what's going
on...

Comment 2

[Peter Weilbacher]

Ah, stupid me! :-) The registry access is only done for the _extended_ ft2lib
functions. How do I test for those?

Comment 3

[Mike Kaply [:mkaply]]

Javier can explain that.

Comment 4

[Mike Kaply [:mkaply]]

Javier has forgotten :)

Basically it had to do with whether or not we use FT2LIB for unicode display.

Try this page:

http://www.columbia.edu/kermit/utf8.html

with and without extended FT2LIB to see the difference.

Comment 5

[jhp (no longer active)]

Basically what Mike said.  OS/2 has no facilities to query a font for the
characters/glyphs it supports.  So I made it so that a user can install the
freetype libs and use that to get better font handling, comparable to what you
would see on some of the other operating systems.

Comment 6

[Peter Weilbacher]

OK, that makes sense and is easy to test. I looked at
http://www.columbia.edu/kermit/utf8.html and
http://en.wikipedia.org/wiki/Greek_alphabet with the patched and unpatched
version and both look identical if I use the same (unicode) fonts.

Btw, I guess gfx_os2.dll can then be added to mozturbo again?
http://lxr.mozilla.org/seamonkey/source/xpfe/bootstrap/os2turbo/mozturbo.cpp#93

Currently I am waiting for Ilya to confirm that we need to bracket the
DosLoadModule with _control87 functions even for registry.dll (before he only
wrote that PMWINX would behave badly when loaded like that).

Comment 7

[Peter Weilbacher]

Attachment: more complete removal of pmwinx

Second try. I removed the FP flags trick for now, which I hope will be solved
at a larger scale soon (bug 280813. Ilya thinks that registry.dll is good
anyway).
This time I also removed pmwinx from the link flags for Sunbird and added
GFX_OS2.DLL again to the libs to load with mozturbo. I don't completely
understand what is done to those DLLs, but it seems to me that it won't trigger
the loading of registry.dll or ft2lib.dll, right?

Comment 8

[Mike Kaply [:mkaply]]

Comment on attachment 173216 [details] [diff] [review]
more complete removal of pmwinx

sr=mkaply

Comment 9

[Andy Willis (abwillis)]

Will this likely get checked in soon?  I opened a bug 281203 that would
partially be corrected by this.  toolkit/library/Makefile.in currently needs
(but doesn't have) the -lpmwinx.  

Comment 10

[Mike Kaply [:mkaply]]

yes. It will go in Monday monrning.

Comment 11

[Mike Kaply [:mkaply]]

All patches checked in to trunk.

Comment 12

[Peter Weilbacher]

Mike, do you think we can apply this patch to the 1.7 (and perhaps aviary)
branch(es)? It didn't seem to have any bad effect on 1.8a6 and 1.8b1, and on the
contrary _seems_ to have fixed problems interacting with other programs.

Although I am not 100% sure that this checkin caused this, but since then I
notice that I can start Mozilla while StarOffice is running which was not
previously the case since about 2004-04-20 the time the Reg* functions were
first added. And I was informed that now (since 1.8b1) ImpOS2 runs when Mozilla
is active which was not previously possible.

I would be happy to produce a clean patch against the current 1.7 and aviary
branches.

Comment 13

[Mike Kaply [:mkaply]]

Sure, no problem. I'll put this patch in 1.7.6 and the next firefox