280215 - [FIX]shouldn't reload pages when going back from page with anchor to original page (foo#bar -> foo)

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

bah, accidentally hit enter.

When loading a page, and clicking an anchor in it, then going back, the page is
reloaded. this sucks for large pages, since they take long to load even from cache.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

most likely a regression from Bug 273158

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

This basically removes the patch in bug 273158 and refixes that bug in a
slightly less intrusive way (only for non-history loads).

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 172701 [details] [diff] [review]
Patch

+    if (hashNew < 0 && (hashCurrent < 0 || aLoadType != LOAD_HISTORY)) {

can you make those comparisons to kNotFound instead?

with that, r=biesi

Comment 5

[Darin Fisher]

Comment on attachment 172701 [details] [diff] [review]
Patch

sr=darin (with same nit as biesi)

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fixed.