[FIX]shouldn't reload pages when going back from page with anchor to original page (foo#bar -> foo)

RESOLVED FIXED in mozilla1.8beta1

Status

()

Core
Document Navigation
P1
normal
RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: Biesinger, Assigned: bz)

Tracking

({regression})

Trunk
mozilla1.8beta1
x86
Linux
regression
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

 
bah, accidentally hit enter.

When loading a page, and clicking an anchor in it, then going back, the page is
reloaded. this sucks for large pages, since they take long to load even from cache.

Assignee: adamlock → nobody
Component: Embedding: Docshell → History: Session
QA Contact: adamlock → history.session
Summary: shouldn → shouldn't reload pages when going back from page with anchor to original page (foo#bar -> foo)
most likely a regression from Bug 273158
Keywords: regression
Created attachment 172701 [details] [diff] [review]
Patch

This basically removes the patch in bug 273158 and refixes that bug in a
slightly less intrusive way (only for non-history loads).
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #172701 - Flags: superreview?(darin)
Attachment #172701 - Flags: review?(cbiesinger)
Priority: -- → P1
Summary: shouldn't reload pages when going back from page with anchor to original page (foo#bar -> foo) → [FIX]shouldn't reload pages when going back from page with anchor to original page (foo#bar -> foo)
Target Milestone: --- → mozilla1.8beta
Comment on attachment 172701 [details] [diff] [review]
Patch

+    if (hashNew < 0 && (hashCurrent < 0 || aLoadType != LOAD_HISTORY)) {

can you make those comparisons to kNotFound instead?

with that, r=biesi
Attachment #172701 - Flags: review?(cbiesinger) → review+

Comment 5

13 years ago
Comment on attachment 172701 [details] [diff] [review]
Patch

sr=darin (with same nit as biesi)
Attachment #172701 - Flags: superreview?(darin) → superreview+
Fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Updated

9 years ago
Component: History: Session → Document Navigation
QA Contact: history.session → docshell
Blocks: 273158
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.