280410 - Use more <label> elements in attachment/create.html.tmpl

Status: VERIFIED FIXED

(Bugzilla :: Attachments & Requests, enhancement)

Description

[Anne (:annevk)]

Comment 1

[Anne (:annevk)]

Attachment: patch #1

Who needs to review this? This also removes the LANGUAGE attribute which is
deprecated in HTML 4.01 Strict.

Comment 2

[Dave Miller [:justdave]]

I seem to recall having problems with some version of Internet Explorer if the
language attribute was missing.  I'm pretty sure we had numerous bugs filed on
it in the past that resulted in those being added to begin with.

Comment 3

[Anne (:annevk)]

Really? Is it mentioned in the history of the file? I do not think any Internet
Explorer would give trouble with that.

Comment 4

[GavinS]

There are many other places in Bugzilla where we do not specify a language in
the <script>

Comment 5

[Dave Miller [:justdave]]

Hmm, I can't find any bugs that mention it, now that I'm looking.  Maybe I was
dreaming. :)  If it breaks anyone I'm sure they'll complain sooner or later.

Comment 6

[Anne (:annevk)]

justdave, could you perhaps check this in? Or do I need to ask someone else?

Comment 7

[Shane H. W. Travis]

Just to give you some perspective on the process...
1) Someone with review privs reviews the patch. If it passes,
2) Dave or Myk approves the patch. Once that's done,
3) Someone with CVS checkin priviliges adds the patch to the trunk.

So no, justdave doesn't usually check stuff in; he's got more than enough other 
things to do.

In your case, all three steps of the process have actually been fairly swift; 
you filed this bug only four days ago, and now it's being added to trunk code. 
True, it's a relatively small bug, but that's still on the speedy end of things 
given the steps a patch has to go through before it becomes final.


Checking in template/en/default/attachment/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tm
pl,v  <--  create.html.tmpl
new revision: 1.19; previous revision: 1.18
done

Comment 8

[Anne (:annevk)]

Thanks for the info!