280497 - Replace "LIMIT" with Bugzilla::DB function call

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Tomas Kopal]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20050110 Firefox/1.0 (Debian package 1.0+dfsg.1-2)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20050110 Firefox/1.0 (Debian package 1.0+dfsg.1-2)

"LIMIT" have MySQL specific syntax and should be replaced with DB
agnostic call to function in the DB compatibility layer.

Reproducible: Always

Comment 1

[Tomas Kopal]

Attachment: V1

Patch replacing all SQL LIMIT occurences with DB compat layer call.

Comment 2

[Max Kanat-Alexander]

Bug should be marked ASSIGNED and re-assigned to yourself, when you take them. :-)

Comment 3

[Max Kanat-Alexander]

Comment on attachment 174194 [details] [diff] [review]
V1

r=mkanat by inspection.

Comment 4

[Dave Miller [:justdave]]

so nobody's actually tested it?

Comment 5

[Tomas Kopal]

(In reply to comment #4)
> so nobody's actually tested it?

I did :-).

Comment 6

[Dave Miller [:justdave]]

fair enough

Comment 7

[Max Kanat-Alexander]

By the way, there was very minor bitrot from the other DBCompat patches, because
some my $dbh statements had already been added. :-) (So no problem, really.)

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.281; previous revision: 1.280
done
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.345; previous revision: 1.344
done
Checking in collectstats.pl;
/cvsroot/mozilla/webtools/bugzilla/collectstats.pl,v  <--  collectstats.pl
new revision: 1.41; previous revision: 1.40
done
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.303; previous revision: 1.302
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.236; previous revision: 1.235
done
Checking in sanitycheck.cgi;
/cvsroot/mozilla/webtools/bugzilla/sanitycheck.cgi,v  <--  sanitycheck.cgi
new revision: 1.79; previous revision: 1.78
done
Checking in userprefs.cgi;
/cvsroot/mozilla/webtools/bugzilla/userprefs.cgi,v  <--  userprefs.cgi
new revision: 1.66; previous revision: 1.65
done
Checking in whine.pl;
/cvsroot/mozilla/webtools/bugzilla/whine.pl,v  <--  whine.pl
new revision: 1.6; previous revision: 1.5
done
Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.77; previous revision: 1.76
done
Checking in Bugzilla/Token.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Token.pm,v  <--  Token.pm
new revision: 1.26; previous revision: 1.25
done
Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.37; previous revision: 1.36
done