Closed Bug 280499 Opened 20 years ago Closed 20 years ago

Replace "TO_DAYS()" with Bugzilla::DB function call

Categories

(Bugzilla :: Bugzilla-General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.20

People

(Reporter: Tomas.Kopal, Assigned: Tomas.Kopal)

References

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20050110 Firefox/1.0 (Debian package 1.0+dfsg.1-2)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20050110 Firefox/1.0 (Debian package 1.0+dfsg.1-2)

"TO_DAYS" is MySQL specific and should be replaced with DB
agnostic call to function in the DB compatibility layer.

Reproducible: Always

Steps to Reproduce:
Blocks: 280493
Attached patch V1Splinter Review
Patch to convert TO_DAYS SQL to DB method call. Requires patch from 281360.
Attachment #174669 - Flags: review?
To Max: sorry, but I don't have the permissions to reassign the bug to myself or
mark is assigned...
Depends on: 281360
OK, I'll talk to justdave and see if we can get you editbugs.
Assignee: general → Tomas.Kopal
Target Milestone: --- → Bugzilla 2.20
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 174669 [details] [diff] [review]
V1

OK, this looks good by inspection and the test suite passes.
Attachment #174669 - Flags: review? → review+
Flags: approval?
Flags: approval? → approval+
Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.349; previous revision: 1.348
done
Checking in collectstats.pl;
/cvsroot/mozilla/webtools/bugzilla/collectstats.pl,v  <--  collectstats.pl
new revision: 1.42; previous revision: 1.41
done
Checking in whineatnews.pl;
/cvsroot/mozilla/webtools/bugzilla/whineatnews.pl,v  <--  whineatnews.pl
new revision: 1.16; previous revision: 1.15
done
Checking in Bugzilla/Chart.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Chart.pm,v  <--  Chart.pm
new revision: 1.5; previous revision: 1.4
done
Checking in Bugzilla/Search.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v  <--  Search.pm
new revision: 1.80; previous revision: 1.79
done
Checking in Bugzilla/Token.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Token.pm,v  <--  Token.pm
new revision: 1.27; previous revision: 1.26
done
Checking in Bugzilla/Auth/Login/WWW/CGI.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth/Login/WWW/CGI.pm,v  <-- 
CGI.pmnew revision: 1.7; previous revision: 1.6
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: