280619 - Clean up BrowserWrapper interaction with BWC

Status: RESOLVED DUPLICATE of bug 283419

(Camino Graveyard :: Tabbed Browsing, defect)

Description

[Simon Fraser [no longer active]]

The BrowserWrapper currently has too much code that looks like:
  if (mIsPrimary)
    [mWindowController doSomething]

and it also has pointers to the url field and status bar, which seems wrong. We
need some better encapsulation here.

Comment 1

[Simon Fraser [no longer active]]

Attachment: First-cut patch (needs work)

Here's a first-cut patch. It's not complete, because there's some fudging (the
[mWindow delegate] calls in BrowserWrapper, mostly).

The basic strategy is to create a new protocol, BrowserUIDelegate, and
implement it in the BWC. The BrowserWrapper has a delegate that implements this
protocol. The BrowserWrapper in the frontmost tab is the only one with a
non-nil delegate.

I've pushed some logic into the BWC (e.g. stuff relating to [mUrlBar
userHasTyped]) where it makes sense.

Comment 2

[Simon Fraser [no longer active]]

This was checked in (under another bug).

*** This bug has been marked as a duplicate of 283419 ***