280728 - calendar names with special characters are left url encoded

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Clint Byrum]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041111 Firefox/1.0 (Debian package 1.0-2)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041111 Firefox/1.0 (Debian package 1.0-2)

When you add a remote calendar by clicking on it in Firefox, the file's name,
without extension, is used as the Calendar Name. If you have, for instance, a
space in the name, the URL Encoded bits are kept that way, so "US Holidays.ics"
produces "US%20Holidays" as the Calendar Name.

Reproducible: Always

Steps to Reproduce:
1. Click a link to an ical file with a space in the filename in Firefox
2. Note url encoded calendar name


Actual Results:  
See attached file for screenshot

Expected Results:  
The url encoding should be decoded.

Comment 1

[Clint Byrum]

Attachment: Screenshot showing URL encoded calendar name.

Comment 2

[Rafael Rivera]

Added to CC.
Can you attach a sample iCal file? Have you tested with a nightly trunk build?

Comment 3

[Martin Schröder [:mschroeder]]

Confirmed with Sunbird trunk build (Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060415 Mozilla Sunbird/0.3a1+).

Comment 4

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

Unescape the calendar name generated from URL or given path to remote calendar.

Comment 5

[Joey Minta]

Comment on attachment 219232 [details] [diff] [review]
Patch v1

http://developer.mozilla.org/en/docs/Core_JavaScript_1.5_Guide:Predefined_Functions:escape_and_unescape_Functions says that unescape is deprecated.  Are you sure we want to be using that here?

Comment 6

[Martin Schröder [:mschroeder]]

Attachment: Patch v2

Thanks for the information. I wasn't aware of that deprecation.

Comment 7

[Joey Minta]

Comment on attachment 219463 [details] [diff] [review]
Patch v2

Looks good to me! r=jminta

Comment 8

[Matthew (lilmatt) Willis]

patch checked in on trunk and MOZILLA_1_8_BRANCH