Closed Bug 280728 Opened 19 years ago Closed 18 years ago

calendar names with special characters are left url encoded

Categories

(Calendar :: Sunbird Only, defect)

Product:
Calendar
Component:
Sunbird Only
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: cbyrum, Assigned: mschroeder)

References

(
URL
)

Details

Attachments

(2 files, 1 obsolete file)

Screenshot showing URL encoded calendar name.
25.56 KB, image/png
Details
Patch v2
1.93 KB, patch
jminta
: first-review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041111 Firefox/1.0 (Debian package 1.0-2)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041111 Firefox/1.0 (Debian package 1.0-2)

When you add a remote calendar by clicking on it in Firefox, the file's name,
without extension, is used as the Calendar Name. If you have, for instance, a
space in the name, the URL Encoded bits are kept that way, so "US Holidays.ics"
produces "US%20Holidays" as the Calendar Name.

Reproducible: Always

Steps to Reproduce:
1. Click a link to an ical file with a space in the filename in Firefox
2. Note url encoded calendar name


Actual Results:  
See attached file for screenshot

Expected Results:  
The url encoding should be decoded.
Added to CC.
Can you attach a sample iCal file? Have you tested with a nightly trunk build?
QA Contact: gurganbl → sunbird
Confirmed with Sunbird trunk build (Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060415 Mozilla Sunbird/0.3a1+).
Assignee: mostafah → nobody
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: PC → All
Version: unspecified → Trunk
Attached patch Patch v1 (obsolete) — — Splinter Review 
Unescape the calendar name generated from URL or given path to remote calendar.
Assignee: nobody → mschroeder
Status: NEW → ASSIGNED
Attachment #219232 - Flags: first-review?(jminta)
Comment on attachment 219232 [details] [diff] [review]
Patch v1

http://developer.mozilla.org/en/docs/Core_JavaScript_1.5_Guide:Predefined_Functions:escape_and_unescape_Functions says that unescape is deprecated.  Are you sure we want to be using that here?
Attached patch Patch v2 — — Splinter Review 
Thanks for the information. I wasn't aware of that deprecation.
Attachment #219232 - Attachment is obsolete: true
Attachment #219463 - Flags: first-review?(jminta)
Attachment #219232 - Flags: first-review?(jminta)
Comment on attachment 219463 [details] [diff] [review]
Patch v2

Looks good to me! r=jminta
Attachment #219463 - Flags: first-review?(jminta) → first-review+
Whiteboard: [needs landing]
patch checked in on trunk and MOZILLA_1_8_BRANCH
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in before you can comment on or make changes to this bug.