280827 - Preferences toolbar needs help tags (tooltips)

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect, P5)

Description

[louis bennett]

The preferences toolbar is very useful if it's set to display icon & text.
However, if you toggle its view to icon-only (by command-clicking the toolbar
control thrice), there should still be a help tag for each icon.

Steps to reproduce:
1. Open Preferences
2. Command-click the toolbar control thrice, such that the toolbar is in its
"Icon Only" mode.
3. Hovering over an icon should produce a help tag, but does not.

Comment 1

[Wevah (Nate Weaver)]

Well, no Apple-supplied applications' preference windows do this...

Comment 2

[Samuel Sidler (old account; do not CC)]

I agree, no other major Mac OS X apps have this (that I can find). This is a
*very* minor bug and probably won't be closed until way after 1.0. I'm targeting
for future and prioritizing as 5.

Comment 3

[Chris Lawson (gone)]

Taking. If I haven't tossed a patch up here within two weeks, someone holler at me.

cl

Comment 4

[Chris Lawson (gone)]

Attachment: Adds tooltip support to preferences toolbar

I've basically modified and duplicated the labelForPane method to create
tooltips instead of labels (in a method called, creatively, toolTipForPane).

This falls back on the same sort of backup names as labelForPane does (if it
can't find something in the pref pane called "PreferencePanelToolTip"). Right
now, that means that the History and Downloads prefs panes get labelled with a
really ugly tooltip (org.mozilla.camino.preference.history). I can add proper
tooltips to the various pref panes if someone wants me to.

cl

Comment 5

[Stuart Morgan]

Why not just set the tooltip to labelForPane: (or at least use that as the backup case)?

Comment 6

[froodian (Ian Leue)]

Attachment: Uses labelForPane

cl, I hope you don't mind me taking this.

This just uses labelForPane, since it works.

Comment 7

[Stuart Morgan]

Comment on attachment 233202 [details] [diff] [review]
Uses labelForPane

r=me

Comment 8

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 233202 [details] [diff] [review]
Uses labelForPane

sr=pink

Comment 9

[Mark Mentovai]

Checked in on the trunk and MOZILLA_1_8_BRANCH.