Preferences toolbar needs help tags (tooltips)

RESOLVED FIXED in Future

Status

Camino Graveyard
Preferences
P5
trivial
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: louis bennett, Assigned: froodian (Ian Leue))

Tracking

({fixed1.8.1, polish})

unspecified
Future
PowerPC
All
fixed1.8.1, polish

Details

Attachments

(2 attachments)

(Reporter)

Description

12 years ago
The preferences toolbar is very useful if it's set to display icon & text.
However, if you toggle its view to icon-only (by command-clicking the toolbar
control thrice), there should still be a help tag for each icon.

Steps to reproduce:
1. Open Preferences
2. Command-click the toolbar control thrice, such that the toolbar is in its
"Icon Only" mode.
3. Hovering over an icon should produce a help tag, but does not.

Comment 1

12 years ago
Well, no Apple-supplied applications' preference windows do this...
I agree, no other major Mac OS X apps have this (that I can find). This is a
*very* minor bug and probably won't be closed until way after 1.0. I'm targeting
for future and prioritizing as 5.
Priority: -- → P5
Target Milestone: --- → Future

Comment 3

12 years ago
Taking. If I haven't tossed a patch up here within two weeks, someone holler at me.

cl
Status: NEW → ASSIGNED

Updated

12 years ago
Assignee: mikepinkerton → bugzilla
Status: ASSIGNED → NEW

Comment 4

12 years ago
Created attachment 198720 [details] [diff] [review]
Adds tooltip support to preferences toolbar

I've basically modified and duplicated the labelForPane method to create
tooltips instead of labels (in a method called, creatively, toolTipForPane).

This falls back on the same sort of backup names as labelForPane does (if it
can't find something in the pref pane called "PreferencePanelToolTip"). Right
now, that means that the History and Downloads prefs panes get labelled with a
really ugly tooltip (org.mozilla.camino.preference.history). I can add proper
tooltips to the various pref panes if someone wants me to.

cl

Comment 5

11 years ago
Why not just set the tooltip to labelForPane: (or at least use that as the backup case)?
(Assignee)

Comment 6

11 years ago
Created attachment 233202 [details] [diff] [review]
Uses labelForPane

cl, I hope you don't mind me taking this.

This just uses labelForPane, since it works.
Assignee: bugzilla → stridey
Status: NEW → ASSIGNED
Attachment #233202 - Flags: review?(stuart.morgan)

Comment 7

11 years ago
Comment on attachment 233202 [details] [diff] [review]
Uses labelForPane

r=me
Attachment #233202 - Flags: superreview?(mikepinkerton)
Attachment #233202 - Flags: review?(stuart.morgan)
Attachment #233202 - Flags: review+
Comment on attachment 233202 [details] [diff] [review]
Uses labelForPane

sr=pink
Attachment #233202 - Flags: superreview?(mikepinkerton) → superreview+
Whiteboard: [needs checkin]

Comment 9

11 years ago
Checked in on the trunk and MOZILLA_1_8_BRANCH.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
You need to log in before you can comment on or make changes to this bug.