CNavDTD::mBodyContext leaking mStyles

VERIFIED FIXED

Status

()

Core
HTML: Parser
P3
normal
VERIFIED FIXED
19 years ago
17 years ago

People

(Reporter: jrohlf, Assigned: harishd)

Tracking

({memory-leak})

Trunk
x86
Windows NT
memory-leak
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

19 years ago
M13:

CNavDTD::CloseContainersTo() calls mBodyContext->Pop() which returns
theChildStyleStack. In those situations when theChildStyleStack is 
passed to RecycleNodes() I believe that it is leaked - the nodes are recycled
but the stack itself is leaked. I added the line "delete aNodeStack" to
the end of RecycleNodes() which reduced number of leaked stacks from 5 to 1
but I don't know what causes that last one to leak.

In general, the code is a bit confusing since nsEntryStack::Push,PushFront,Pop
all set mStyles to 0 without first deleting it which at first glance is a leak.
However, it appears that Pop() is only called from nsDTDContext::Pop() which
grabs and returns mStyles in which case nsEntryStack::Pop() would not leak
the mStyles. I don't know if Push(), PushFront() behave similarly to Pop().
(Assignee)

Comment 1

19 years ago
Rick, I think I've a fix for this in my tree. Infact, this could be a dup of bug
29048.
Keywords: mlk
(Assignee)

Comment 2

18 years ago
Since it's a possible dup of 29048..I'll take this bug...for further analysis.
Assignee: rickg → harishd
(Assignee)

Comment 3

18 years ago
I'm pretty sure that this leak has been fixed by my previous change..

Marking bug FIXED.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

18 years ago
Now, am not sure about this fix... Let me reopen this for now.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 5

18 years ago
Fix is in.
Status: REOPENED → RESOLVED
Last Resolved: 18 years ago18 years ago
Resolution: --- → FIXED

Comment 6

18 years ago
updated qa contact.
QA Contact: janc → bsharma

Comment 7

17 years ago
Marking verified as per above developer comments.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.