280923 - svg element does not apply width and height settings from CSS

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Harald Albrecht]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b) Gecko/20050201 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b) Gecko/20050201 Firefox/1.0+

<svg> elements do not apply their width and/or height settings from CSS.
Instead, only the values directly set through the width= and height= attributes
of <svg> elements are used.

Reproducible: Always

Steps to Reproduce:
1. Use attached testcase file.


Actual Results:  
The black circle is shown completely. However, if the width and height CSS
settings would be properly honored, then only the topleft quarter of the black
circle should be shown.

Expected Results:  
The black circle should be clipped, so that only its topleft quarter should be
visible.

Comment 1

[Harald Albrecht]

Attachment: Testcase: svg element has its width and height set by internal CSS, should clip black circle

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: simpler testcase

Comment 3

[Jonathan Watt [:jwatt]]

I meant simpler *testcase* of course. As Harald says, it works fine if we use
the attributes.

Comment 4

[Boris Zbarsky [:bzbarsky]]

So isn't this just a matter of mapping width/height into CSS on outer SVG
elements and then actually using the reflow state data when you reflow?

Comment 5

[Jonathan Watt [:jwatt]]

Well first I was wondering whether we should be doing this.

Comment 6

[Justus Piater]

See also bug #288276

Comment 7

[Jonathan Watt [:jwatt]]

Boris: so given http://lists.w3.org/Archives/Public/www-svg/2006Feb/0051 I guess this isn't quite as you describe in comment 4?

Comment 8

[Boris Zbarsky [:bzbarsky]]

Yeah, given that these are intrinsic sizes not specified sizes...

Comment 9

[Jonathan Watt [:jwatt]]

The SetCoordCtxRect call in nsSVGOuterSVGFrame::Reflow is just wrong. We should only be doing that if there's no viewBox attribute.

Comment 10

[Jonathan Watt [:jwatt]]

Moving deps to bug 294086.

Comment 11

[Jonathan Watt [:jwatt]]

This bug was fixed by the fix for bug 294086. A lot of the reftests checked in for that bug cover this bug too, so marking in-testsuite+.