281139 - crash doing onfocus="alert()" and Reloading [@ nsEventStateManager::PreHandleEvent]

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Mats Palmgren (inactive)]

crash doing onfocus="alert()" and Reloading.

There are a few earlier crash bugs on nsEventStateManager::PreHandleEvent,
but none of them seemed like a dupe.

STEPS TO REPRODUCE:
1. load attached testcase
2. click the button in the page
3. when the alert pops up, hold CTRL+R down and then click OK a few times

100% reproducable in a Linux debug build of todays date.

I was NOT able to crash 2005-02-02-05 trunk Linux, but I'm guessing it
could crash for someone else, perhaps on a slower computer or different OS.

Comment 1

[Mats Palmgren (inactive)]

Attachment: Testcase

Comment 2

[Mats Palmgren (inactive)]

Attachment: Crash data

Comment 3

[Alex Vincent [:WeirdAl]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050213 crash
OS -> All

Comment 4

[Anne (:annevk)]

See also bug 225302 and bug 105129.

Comment 5

[Boris Zbarsky [:bzbarsky]]

So the problem there is that the presshell is already destroyed, right?

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: proposed patch

Comment 7

[Adam Guthrie]

*** Bug 324562 has been marked as a duplicate of this bug. ***

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Checking in nsEventStateManager.cpp;
/cvsroot/mozilla/content/events/src/nsEventStateManager.cpp,v  <--  nsEventStateManager.cpp
new revision: 1.632; previous revision: 1.631
done

Comment 9

[Boris Zbarsky [:bzbarsky]]

smaug, how do you feel about this patch for branches?  Is it safe?  If so, we probably want it.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

I thought it is safe, but there is Bug 336582 (which I haven't been 
able to reproduce)

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 209621 [details] [diff] [review]
proposed patch

This didn't cause Bug 336582. So asking approval for branches. Should be safe crash fix.

Comment 12

[Daniel Veditz [:dveditz]]

Comment on attachment 209621 [details] [diff] [review]
proposed patch

approved for 1.8.0 branch, a=dveditz for drivers

Comment 13

[Tracy Walker [:tracy]]

verified with:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.5) Gecko/20060620 Firefox/1.5.0.5

Comment 14

[Adam Guthrie]

*** Bug 345545 has been marked as a duplicate of this bug. ***