281237 - New feed subscription dialog

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[Scott MacGregor]

The UI I designed for the 1.0 release doesn't work very well when you have a
large number of feeds and when you have a large number of feeds associated with
a particular foldder. I always meant to re-write it as a nsITreeView so we can
add extra levels of containment to the UI (i.e. showing the folders and the
feeds contained under each folder).

Tracking bug for these changes.

Comment 1

[Scott MacGregor]

Attachment: work in progress

just saving my work. Still a lot more to do.

Comment 2

[Scott MacGregor]

Getting Robert in the loop on the subscription redesign as I'm hoping between
the two of us we can get the OPML stuff integrated into the new dialog as well. 

Comment 3

[Scott MacGregor]

Attachment: updated patch

1) adds support for add and remove feed buttons
2) support for drag and drop of RSS feeds into the RSS manager
3) Confirm deletion of RSS feeds from this dialog

Still to do:
Figure out what to do about edit support

Comment 4

[Scott MacGregor]

Attachment: screen shot

Comment 5

[Scott MacGregor]

Attachment: updated patch

saving a snap shot. improved drag and drop support, bug fixes for edit/remove
feed items, add back the status and progress UI.

Comment 6

[Scott MacGregor]

Attachment: updated patch

includes license file changes, adding a feed now checks to see if the feed
already exists before adding, CSS work for Mac OS X, verbage changs to the
dialog, drag and drop no longer freezes the dragging application (i.e. Firefox)
while the feed properties dialog is waiting on the user.

I'm going start landing this now and then continue with incremental changes
after it has landed. For instance, I'd like to add dragging of feeds within the
dialog in addition to making the view smarter about reacting to new feeds
instead of just rebuilding the view from scratch. I also need to make the
dialog a folder listener to track changes to the rss server while it is open.

Comment 7

[David Fraser]

How will this also handle storing feeds in sub-folders of folders?

Comment 8

[Scott MacGregor]

Attachment: add support for dragging and dropping existing feeds

supplemental patch which allows you to drag feeds from one folder to another
from within the subscriptions dialog.

Comment 9

[Scott MacGregor]

Attachment: add support for editing existing feeds

make double click and VK_ENTER/VK_RETURN bring up the edit feed dialog

Comment 10

[Scott MacGregor]

marking fixed. Any future issues (such as making the dialog react to folder
additions/removals from the main 3 pane window) can be tracked in separate bugs. 

Comment 11

[Doug Wright]

"Removing or changing the folder for a feed will not effect previously
downloaded articles" should use "affect" instead of "effect"

Comment 12

[Scott MacGregor]

how sure are you that its affect not effect before I change it...:)

Comment 13

[David :Bienvenu]

it is "affect".

Comment 14

[Scott MacGregor]

ok, fixed :)

Comment 15

[alaskan]

Hi, I'm unable to import an OPML file created with TB 1.5b1

IE: I export my subs to an OPML file, clear my subs and then cannot read back my
OPML.