Closed Bug 281551 Opened 20 years ago Closed 19 years ago

[gtk2] Drop down lists do not open immediatly with certain CSS configuration

Categories

(Core Graveyard :: GFX: Gtk, defect)

Product:
Core Graveyard
Component:
GFX: Gtk
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1beta2

People

(Reporter: thomas.petazzoni, Assigned: iamawalrus)

References

Details

(Keywords: fixed1.8.1)

Attachments

(2 files)

Reporters testcase
756 bytes, text/html
Details
patch
736 bytes, patch
bryner
: review+
roc
: superreview+
mtschrep
: approval1.8.1+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.7.5) Gecko/20050206 Firefox/1.0 (Debian package 1.0+dfsg.1-5) Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.7.5) Gecko/20050206 Firefox/1.0 (Debian package 1.0+dfsg.1-5) Inside a form, if you put a "select" with some options, and then apply a ":focus" CSS class, there are certain conditions for which you have to click 3 times on the drop down list to open it, instead of one time. If the :focus CSS class contains : - background-color + border + color : PROBLEM - background-color + color : PROBLEM - border + color : PROBLEM - color : no problem Reproducible: Always Steps to Reproduce: 1. Use the following HTML file (W3 validated) <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html> <head> <title>Title</title> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-15"/> <link rel="stylesheet" type="text/css" href="test.css" /> </head> <body> <form action="plop.html" method="post"> <p>Select: <select class="formulaire"> <option value="3">Allemand</option> <option value="2">Anglais</option> <option value="7">Basque</option> </select> </p> </form> </body> </html> 2. Use the following CSS (W3 validated) .formulaire { border: solid 1px black; font-size: 12px; background-color: #fffbf7; color: #000000; } .formulaire:focus{ background-color: #eeeae6; border: 1px solid #777; color: #000000; } 3. Load the page in your browser 4. Click on the drop down list. Three clicks are necessary to open it. Actual Results: With some CSS attributes, drop down lists require 3 clicks to open. Expected Results: Whather the CSS attributes are, drop down lists should open in only one click.
Attached file Reporters testcase —
WFM :Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050205 Firefox/1.0+
The drop-down named "Revues" has to be clicked three times to show the list of itmes : http://www.persee.fr/
Here, with Firefox 1.0 under GNU/Linux, the drop-down list at www.persee.fr works with just one click.
Status: UNCONFIRMED → NEW
Ever confirmed: true
This is a bug quite similar with bug 241187. However, the patch in 241187 only fixed part of the problem. I found it is hard to cache the visibility status when the nsWindow represents a toplevel window.
Attached patch patch — — Splinter Review
read the real visibility status when the nsWindow is a toplevel
Attachment #176682 - Flags: review?(bryner)
Attachment #176682 - Flags: review?(bryner) → review+
Attachment #176682 - Flags: superreview?(blizzard)
Attachment #176682 - Flags: superreview?(blizzard) → superreview?(firefox)
blizzard@mozilla.org would probably be a better choice for sr, Blake hasn't been actively reviewing lately.
I have requested sr from blizzard for several weeks and even sent mail directly to him but got no response. Anyone else I can seek sr from?
(In reply to comment #7) > I have requested sr from blizzard for several weeks and even sent mail directly > to him but got no response. Anyone else I can seek sr from? brendan@mozilla.org, dveditz@cruzio.com, and scc@mozilla.org are listed as catch-alls, and for a small patch that already has r=bryner they should be willing to help you out. Finding one of these people on IRC and asking about it will probably increase your chances of getting sr.
Attachment #176682 - Flags: superreview?(firefox) → superreview?(dveditz)
Blocks: 149981
Also related: bug 154670.
Assignee: firefox → robin.lu
Blocks: 154670
I'm Observing this Problem only with Unix Clients: Debian Linux (i386): - Firefox 1.0.3 SuSE Linux: - Firefox 1.0 Solaris (i386): - Mozilla 1.7 - Firefox 1.0.4 Under Windoes there isn't any Problem.
because it is a gtk2 only bug. I have requested sr for two monthes. I do appreciate if someone can help on super-reivewing the patch. Thanks in advance.
Component: General → GFX: Gtk
Flags: review+
Product: Firefox → Core
Summary: Drop down lists do not open immediatly with certain CSS configuration → [gtk2] Drop down lists do not open immediatly with certain CSS configuration
Version: unspecified → Trunk
Attachment #176682 - Flags: review+
Robin's patch fixed all of the three bugs that this one blocks. It'd be great to get this patch in.
Blocks: 163503
Attachment #176682 - Flags: superreview?(dveditz) → superreview?(roc)
FWIW, I can't reproduce this bug anymore with Firefox 1.5 on Debian sid.
Attachment #176682 - Flags: superreview?(roc) → superreview+
Patch checked in by timeless.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
*** Bug 317306 has been marked as a duplicate of this bug. ***
*** Bug 248910 has been marked as a duplicate of this bug. ***
*** Bug 280434 has been marked as a duplicate of this bug. ***
Doesn't GTK1 need the same fix?
Comment on attachment 176682 [details] [diff] [review] patch Is this a branch-suitable patch? Focus issues suck.
Attachment #176682 - Flags: approval-branch-1.8.1?(bryner)
Attachment #176682 - Flags: approval-branch-1.8.1?(bryner) → approval1.8.1?
Attachment #176682 - Flags: approval1.8.1? → approval1.8.1+
mozilla/widget/src/gtk2/nsWindow.cpp 1.145.2.5
Keywords: fixed1.8.1
Target Milestone: --- → mozilla1.8.1beta2
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: