281574 - Combine version_/milestone_/component_no_action errors into one.

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Shane H. W. Travis]

These three entries in user-error.html.tmpl are identical, save for one word. 
These could easily be combined into one 'no_valid_action' error message, and 
the one word passed in as a field.

Patch to follow.

Comment 1

[Shane H. W. Travis]

Attachment: Code patch for tip

I'm about to need this as part of bug 98123... so rather than make another
identical error message, I thought I'd clean things up a bit.

Comment 2

[Frédéric Buclin]

Comment on attachment 173804 [details] [diff] [review]
Code patch for tip

>+ThrowUserError('no_valid_action', {'name' => "milestoness"});

milestones with one 's'!


Else it's good: r=LpSolit

Comment 3

[GavinS]

not localisable though.....

Comment 4

[Shane H. W. Travis]

Attachment: Code patch for tip, take 2

Gavin makes a good (if frustrating) point... so here's a version that works
with localization.

Comment 5

[Frédéric Buclin]

Comment on attachment 173867 [details] [diff] [review]
Code patch for tip, take 2

r=LpSolit

Indeed much better! :)

Comment 6

[Shane H. W. Travis]

Checking in editcomponents.cgi;
/cvsroot/mozilla/webtools/bugzilla/editcomponents.cgi,v  <--  editcomponents.cgi
new revision: 1.46; previous revision: 1.45
done
Checking in editmilestones.cgi;
/cvsroot/mozilla/webtools/bugzilla/editmilestones.cgi,v  <--  editmilestones.cgi
new revision: 1.30; previous revision: 1.29
done
Checking in editversions.cgi;
/cvsroot/mozilla/webtools/bugzilla/editversions.cgi,v  <--  editversions.cgi
new revision: 1.29; previous revision: 1.28
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-
error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.88; previous revision: 1.87
done