281736 - No database being available results in an internal server error

Status: RESOLVED DUPLICATE of bug 168366

(Bugzilla :: Attachments & Requests, defect)

Description

[Colin Ogilvie [:cso]]

justdave restarted the database on BMO tonight, just as I was trying to load the
URL above. This resulted in an Internal Server Error rather than a Bugzilla
Error, which would probably be best.

Comment 1

[Max Kanat-Alexander]

Hrm. I think that the Bugzilla::DB enhancements that we're working on in bug
237862 will help, here, maybe.

I'm assuming that this doesn't only happen on the attachments screen, so I'm
changing the summary. :-)

Comment 2

[Tomas Kopal]

I would guess that the DB layer will not help here.
What I assume is happening is that one of the SendSQL or $dbh->execute calls
fails with exception. We don't do any error checking there (and it would clutter
the code a lot if we did), but the DBI error catching is turned on. So I expect
when error happens, DBI spits error to stderr (i.e. system log) and exits with
error (thus causing internal error page to show up).
There is a DBI errror handler in the Bugzilla/DB.pm module, but currently it
only trims the error message to reasonable length. We should probably modify it
to call ThrowCodeError (or maybe even new ThrowDBError or so) to create
meaningful error page. Problem is that we may already created part of the page
at that moment, so it needs to be done carefuly to get correct html at all times...

Comment 3

[Frédéric Buclin]

*** This bug has been marked as a duplicate of 168366 ***