281770 - Reset button on the fonts prefpane resets all fonts instead of just active language/script

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Preferences, defect, P3)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Every option/control on the Fonts tab of the Appearance prefpane affects *only*
the setting for the active ("Choose fonts for:") language/script--except for
"Reset", which resets the font settings for *all* scripts/languages.

This is bad UI.  The user expects the buttons/selects to only operate on the
active language/script, but instead one of them (Reset) acts on all scripts
regardless of which one is active.

(If en masse is the only way Gecko lets one reset fonts, then the "Reset" button
needs to be renamed or have a bit of explanatory text to the effect of "Reset
all font settings for all languages/scripts")

Comment 1

[Simon Fraser [no longer active]]

Taking.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Zipped sample of Camino hanging after resetting fonts

If you have several tabs open, resetting fonts (as currently implemented, e.g.
for all langGroups) can cause Camino to beachball and suck 60-80% of CPU (it's
redrawing all the tabs).  

If you have a sufficient number or they are "big" enough--and I don't know a
threshold; more than 5 but less than a dozen--Camino will become irrevocably
hung.  Attached is a zipped sample of a hung Camino when I had 8 or 9 tabs open
and hit "Reset."

Comment 3

[Simon Fraser [no longer active]]

Are you sure you waited long enough? Yeah, I know this sucks, but it's entirely
in gecko.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I waited a couple of minutes.  By then, Activity Monitor reported "(hung)" in
red, I waited a little while before I sampled it and then force quit.

Comment 5

[Julian Pellico]

(In reply to comment #0)
> 
> This is bad UI.  The user expects the buttons/selects to only operate on the
> active language/script, but instead one of them (Reset) acts on all scripts
> regardless of which one is active.
> 
> (If en masse is the only way Gecko lets one reset fonts, then the "Reset" button
> needs to be renamed or have a bit of explanatory text to the effect of "Reset
> all font settings for all languages/scripts")

Ugh...I worked on this for bug 158180. I'm pretty sure my nib quite clearly
indicated that the button resets all scripts.

I suppose I decided single-handedly that the Reset button should apply to all
scripts.

Also, re the performance issue/hang. Gecko is terribly slow at re-rendering a
page after font changes. However, this problem seems worse using the Reset
button than commiting font changes after switching prefs. I do not recall this
being the case originally. It looks like it re-renders the page, then beachballs
while doing who knows what. It also looks like the page is redrawn with the
wrong fonts; reloading the page seems to fix it.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #5)
> It also looks like the page is redrawn with the
> wrong fonts; reloading the page seems to fix it.

I believe there's a Core bug on that.  Spinning the hanging stuff off into bug
303987.

Comment 7

[Samuel Sidler (old account; do not CC)]

-> 1.1

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Mass un-setting milestone per 1.6 roadmap.

Filter on RemoveRedonkulousBuglist to remove bugspam.

Developers: if you have a patch in hand for one of these bugs, you may pull the bug back to 1.6 *at that point*.

Comment 9

[Stuart Morgan]

So do we want to re-label the button, or change its behavior (or add a button and do both)? Either would be pretty easy, so we should just pick something and do it.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

"Reset All" and "Reset" ?

That's OK, presuming that moving min-font and default proportional from the sheet don't make a two-button scenario too cramped.  If they do, then Reset should just reset the active script (both for sanity and perf reasons).

Comment 11

[Chris Lawson (gone)]

I'd like to get this done sooner rather than later; we need to make a decision on comment 10 (which I fully agree with, for the record).

Comment 12

[Chris Lawson (gone)]

Here's a very quick mockup of what comment 10 could look like:

http://chrislawson.net/camino/mockup.png