281833 - nsIDOMLocation::Assign crashes if called from C++ while page is loading.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Doron Rosenberg (IBM)]

http://lxr.mozilla.org/seamonkey/source/dom/src/base/nsLocation.cpp#329, 
loadInfo is null.

This happens during laying out of the page, calling from C++.  I have a weak ref
domElement, then ->GetOwnerDocument(), get a nsIDOMDocumentView, then the
nsIDOMAbstractView, then a nsIDOMWindowInternal, from which I get nsIDOMLocation
and call ->Assign() with an url.  Crash.

So basically changing the location before the page has completed loading and
rendering.

Comment 1

[Boris Zbarsky [:bzbarsky]]

jst, the problem is that the CheckURL code bails out if it has no JS context,
and never creates the loadinfo....  I'm not quite sure what the right fix is
here.  For example, what should we use for the security check, if anything?

Comment 2

[Johnny Stenback (:jst)]

Attachment: Maybe just like this?

Doron, wanna test this? This skips the security check n' all that if called
from C++. And in addition, the loadinfo object that we create won't have an
owner or referrer, so your milage may vary if you use this. There's better ways
to load pages from C++ code than to use the DOM API, but that's a different
story...

Comment 3

[Doron Rosenberg (IBM)]

I am fine using nsIWebNavigation - we just should't crash :)

Comment 4

[Johnny Stenback (:jst)]

Doron, were you able to test this patch?

Comment 5

[Doron Rosenberg (IBM)]

patch worked, ->Assign modifed the loaded URL, no crash!

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 174095 [details] [diff] [review]
Maybe just like this?

r+sr=bzbarsky

Comment 7

[Johnny Stenback (:jst)]

Fixed.