282124 - Remove globals.pl and CGI.pl from editclassifications.cgi

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

This script doesn't really need these libraries. The calls to them can be safely
removed with only minor changes.

Comment 1

[Max Kanat-Alexander]

Attachment: Remove libraries from editclassifications.cgi

Comment 2

[Max Kanat-Alexander]

Attachment: v1.1 (changed $vars)

This makes it more exactly like what globals.pl used to do.

Comment 3

[Dave Miller [:justdave]]

Question: are any of those perl modules depending on being able to access $::vars?

We need to make sure the modules aren't expecting $::vars to exist as well.

(If you've done that, say so and you've got my approval)

Comment 4

[Max Kanat-Alexander]

Oh, good point.

Of course, doesn't having a "my $vars" in the CGI actually create a $main::vars?
That is, isn't the CGI $main? I'll investigate it, though. We're not using too
many of the module functions.

Comment 5

[Max Kanat-Alexander]

OK, so nothing that we use depends on the global $::vars:

[mkanat@landfill mkanat]$ grep -R "::vars" Bugzilla*
Bugzilla/Flag.pm:# so I have to use them as $::template and $::vars in the
package code.
Bugzilla/Flag.pm:    $::vars->{'flag'} = $flag;
Bugzilla/Flag.pm:      $::template->process($template_file, $::vars, \$message);
Bugzilla/Token.pm:    my $vars = $::vars;
Bugzilla/Token.pm:    my $vars = $::vars;
Bugzilla/Token.pm:    my $vars = $::vars;
Bugzilla/User.pm:    my $vars = $::vars;

That Bugzilla::User function is match_field, which we definitely don't use. :-)

So we're good to go.

Comment 6

[Dave Miller [:justdave]]

(In reply to comment #4)
> Of course, doesn't having a "my $vars" in the CGI actually create a $main::vars?

"my $vars" creates a variable which is not in a namespace, and is scoped locally
to the current code block.  It can't be referenced from outside the block of
code containing it. (think braces {} )

> That is, isn't the CGI $main?

Only if it's running standalone.  If it's running under mod_perl, the CGI will
be ModPerl::PerlRun::ROOT::editcomponents_e2cgi:: or something to that effect,
and $::vars will still refer to main::.

Note that |use vars qw( $vars )| will import $::vars into the local namespace so
it can be referenced as $vars, so make sure you're looking for that as well when
looking in the modules.

> I'll investigate it, though. We're not using too many of the module functions.

In the long run, it'd probably be best that we fix the modules to require $vars
to be passed in to them instead of looking for it at $::vars.

Comment 7

[Max Kanat-Alexander]

Checking in editclassifications.cgi;
/cvsroot/mozilla/webtools/bugzilla/editclassifications.cgi,v  <-- 
editclassifications.cgi
new revision: 1.4; previous revision: 1.3
done