Status

()

Core
General
RESOLVED FIXED
14 years ago
10 years ago

People

(Reporter: Brian Ryner (not reading), Assigned: Brian Ryner (not reading))

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

14 years ago
Before starting on bug 21296, I decided to clean up all of the unnecessary crap
in WebShellWindow/XULWindow.
(Assignee)

Comment 1

14 years ago
Created attachment 174278 [details] [diff] [review]
patch

The cleanup here is pretty across-the-board, ranging from removing unused
members to removing redundant code to eliminating nsIWebShellWindow entirely.
(Assignee)

Comment 2

14 years ago
Created attachment 174279 [details] [diff] [review]
diff -w for easier reviewing
Attachment #174279 - Flags: superreview?(bzbarsky)
Attachment #174279 - Flags: review?(danm.moz)
Comment on attachment 174279 [details] [diff] [review]
diff -w for easier reviewing

>Index: xpfe/appshell/public/nsIAppShellService.idl
>-   * @param aShowWindow the window remains invisible if PR_FALSE.
>-   * @param aLoadDefaultPage controls whether the window should try to
>-   *                         load a default content page on its own.

It's worth documenting that the newly-created window will not be visible until
it's manually shown, I think....

sr=bzbarsky with that.	Good to see this cleanup!
Attachment #174279 - Flags: superreview?(bzbarsky) → superreview+

Comment 4

14 years ago
Comment on attachment 174279 [details] [diff] [review]
diff -w for easier reviewing

Wow. So much cruft. By the way I happened to notice you can just get rid of
this local variable, rather than moving it

@@ -359,6 +347,8 @@ nsAppShellService::JustCreateTopWindow(n
       }  
     }

+  PRBool intrinsicallySized = PR_FALSE;
+
Attachment #174279 - Flags: review?(danm.moz) → review+
(Assignee)

Comment 5

14 years ago
checked in.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED

Updated

10 years ago
Component: XP Miscellany → General
QA Contact: brendan → general
You need to log in before you can comment on or make changes to this bug.