282527 - certutil -C changes -8 (dns alt name ext) option to -7 (email ext)

Status: RESOLVED FIXED

(NSS :: Tools, defect, P2)

Description

[Neil Williams]

Attempting to add a DNS alt name extension yields a cert with an extension with
type RFC822Name which is in error. I believe this behavior is explained by the
following 2 lines in AddSubjectAltNames() in nss/cmd/certutil.c

1733         current->type = type;
1734         current->type = certRFC822Name;

Comment 1

[Wan-Teh Chang]

Good catch, Neil.  Obviously, one of those
two lines is wrong.  I think the second line
should be removed.

Comment 2

[Wan-Teh Chang]

This bug was in Bob Relyea's first
implementation of the feature (bug 122863).
In hindsignt it's obvious that the new
line

    current->type = type;

was intended to replace the old line

    current->type = certRFC822Name;

Comment 3

[Wan-Teh Chang]

Attachment: Proposed patch

Comment 4

[Neil Williams]

(In reply to comment #3)
> Created an attachment (id=175219) [edit]
> Proposed patch
> 

Reviewed the proposed patch. It does the trick.

Comment 5

[Wan-Teh Chang]

Thanks, Neil.  I checked in the patch on
the trunk for NSS 3.10.

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

Setting priorities on unprioritized bugs resolved fixed for NSS 3.10.

Comment 7

[Robert Relyea]

Comment on attachment 175219 [details] [diff] [review]
Proposed patch

r+ relyea