28254 - Should add servers' folders restriction for UI & functionality in New folder dialog

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[Karen Huang]

02-16-08-M14 all platforms commercial build:

Should add servers' folders restriction for UI & functionality in New folder
dialog

This bug is related to bug#20879.

For some specific servers (ex:UW IMAP server), the servers' subfolders can be
either a folder-only folder or message-only folder.. so we should add the
servers' folders restriction UI & functionality in New folder dialog.

Comment 1

[Phil Peterson]

Does the 4.x product do this? 

Comment 2

[Karen Huang]

Yes. It is. 
But it needs to uncheck "server supports folders that contain subfolders & 
messages" from the IMAP server's Advanced dialog.

Comment 3

[Karen Huang]

QA-me

Comment 4

[selmer (gone)]

Phil found a way to weasel out of owning this bug.  Reassigning.

Comment 5

[selmer (gone)]

CC Jennifer to see if we need UI input for this.

Just guessing here, but assign to putterman, mark M16 as possible beta2 stopper.
 If this is wrong, please adjust.

Comment 6

[scottputterman]

reassigning to jefft who I think would be the owner of this bug. please reassign 
if I'm wrong.

Comment 7

[selmer (gone)]

Not beta2 stopper, marking M18.  Please add beta2 keyword if you disagree.

Comment 8

[lchiang]

This would be a feature.  Are we going to do this for Beta2 for interop?

Comment 9

[Karen Huang]

Adding [FEATURE] on the summary based on Lisa's comments. 
So who will decide whether this feature will be in beta2 or not?

Comment 10

[Karen Huang]

Per bug 20879 Jeff comments, should this bug assign to Seth? Ccing Seth.

Comment 11

[jefft]

Seth, you're doing the new folder dialog, do you? 

Comment 12

[Ben Bucksch (:BenB)]

The context menu entry |New folder...| should be greyed out completely, if it's
a folder-only folder.

<quote author=me src="http://bugzilla.mozilla.org/show_bug.cgi?id=20879">
[I think, we need to fix this bug], even
if it only means appending a "/" for the implementation. I think, I know UW-IMAP
to some extent :), but it was not clear to me, that I could create a folder-only
folder by just specifying "<name>/", before I saw it at Karen's examples. I dare
to claim, that less experienced users will come to the conclusion, that they are
not at all able to create folders within folders, unless we provide UI for it.
The server pref is less of a problem, because it can be specified by an
administrator.
</quote>

Comment 13

[Karen Huang]

Ben, I thought that the Context menu/create new subfolder should grey out for  
message-only folder (which is the folder with the "Noinferior" flag), isn't it?
And I think we should address the context menu to separate bug...either you or I 
can log that bug.....

Comment 14

[Karen Huang]

So, may I ask: who will take care of the new folder dialog design for this 
specific IMAP server(ex. UW IMAP server)?

Comment 15

[jefft]

Either seth or me. Doesn't matter.

Comment 16

[Karen Huang]

Clear nsbeta2- & nsbeta2 since beta2 is over.
Adding nsbeta3 for the keywords.

Comment 17

[lchiang]

- per mail triage

Comment 18

[Karen Huang]

Without this fix, I couldn't create/specify folder-only or message-only folder 
for specific UW IMAP server.....since create folder-only or messages-folder only 
will be the basic functionality for UW IMAP server. I am removing the nsbeta3- 
to re-evaulte again.....

Comment 19

[selmer (gone)]

Adding Kevin to the CC list.  Kevin, how high do you rate the ability to create
folder-only and message-only folders on UW Imap?

Comment 20

[kmurray1115]

Let's see, the last time we minused a UW UI bug, we got educated by either
mscott or bienvenu on their ubiquity. Also, I thought that UW IMAP servers only
allowed single-use behavior, so is the question redundant? Our previous
rationale was "IT Admins setting up UW IMAP servers will know that UW IMAP
servers do not allow dual use..."  So, if that's not a true statement, then we
should plus this bug. Additionally, we are making plus decisions based on
whether it is important enough to displace another bug on our plus list. So if
you can find one that should come off the list in favor of putting this one on,
by all means offer it up. -Kevin

Comment 21

[Karen Huang]

Just remind PDT team: UI freeze will be on 9/15. We better decide this will be 
nsbeta3+ or nsbeta3- earlier....

Comment 22

[selmer (gone)]

Jeff, what is your recommendation?

Comment 23

[lchiang]

Karen - so you can't create any folders at all for UW servers?

Comment 24

[jefft]

I would suggest nsbeta3+. We should pay attention to the pref whether the server 
support dual use of message-only or both capability. We need to provide user a 
way of creating folder-only mail folder.

Comment 25

[Karen Huang]

Answer Lisa's question:
On Netscape6.0:
1) Users still can create UW folder, but it will default to create message-only 
folder on 6.0.
2) With above default, if users tried to create subfolder under the 
messages-only folder, nothing happening, no subfolders have been created and no 
error, users probably will lost at this point.
3) Without specifying from this new folder dialog for UW, users won't 
understand why they cannot create subfolders under the message-folder.
4) Since bug 20879 (Support "dual_use_folders" = false) already fixed, we really 
need to fix this bug for consistency.

Comment 26

[selmer (gone)]

nsbeta3+, P3.  If we can't get this fixed in time, we need to remove the 
non-functional UI for the pref...

Comment 27

[jefft]

Based on the 6.0 implementation this bug seems not easy to fix. Two problems 
need to be addressed here:

1) allow users to specify whether they want to create a folder-only or 
message-only mail folder
2) we need to grey out (not allow user to pick) the message-only folder when we 
present the parent folder picker popup menu

1) is doable however 2) is hard. Currently we use nc:CanCreateSubfolder as a 
rule to indicate whether we should grey out the folder or not, we check whether 
the folder has the \Noinferior flag or not. We use lsub command instead of list 
command (list command doesn't work well with UW server). We only list Inbox and 
Trash folder but not other folders. \Noselect flag on UW server tells us that 
the mail folder is a folder-only mailbox. It seems hard to work out a logic for 
both UW server and other server to check whether a folder has \Noinferior or 
\Noselect flag. More time needed here.

Comment 28

[selmer (gone)]

So, is the capability of creating these folders worth the pain of getting an
error message when you select a message-only parent?

Comment 29

[jefft]

The error message comes free from the server. User should be prompted with a 
message saying that the folder cannot be selected. 

Comment 30

[selmer (gone)]

mailtriage consensus is that we should implement the dialog and let the bad
folders be in the menu.  (That is, implement your (1) but not (2).)

Comment 31

[jefft]

Attachment: Fixes for both (1) and (2)

Comment 32

[jefft]

Fix checked in.

Comment 33

[kmurray1115]

I guess #2 wasn't *that* hard to fix. ;-)
Nice job!
-Kevin

Comment 34

[Karen Huang]

Verified on all the platforms:
WinNT 09-13-12-M18 commercial build
Linux 09-13-12-M18 commercial build
Mac 09-13-12-M18 commercial build

Verify fix for both:
1) allow users to specify whether they want to create a folder-only or 
message-only mail folder
2) we need to grey out (not allow user to pick) the message-only folder when we 
present the parent folder picker popup menu

Great job! Jeff. Marking as verified!!