282608 - Use SVRCORE functions from either NSS or separate SVRCORE

Status: RESOLVED FIXED

(Directory :: LDAP C SDK, defect)

Description

[Rich Megginson]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040805 Netscape/7.2
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040805 Netscape/7.2

The internal ldap c sdk builds we do for Red Hat (and prior to that Netscape,
and probably still at Sun) use a library called SVRCORE.  It provides two
services, only one of which is used in the ldap sdk - the pin management
services.  These are defined in a header file called svrcore.h.  The other
service is server side SSL set up, in servssl.h, which is old, crufty, and
apparently hasn't been used in a long time.

I'm working on moving SVRCORE into NSS.  We need to be able to build the LDAP C
SDK with SVRCORE pin management, either by using the old SVRCORE or the new NSS
library.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Rich Megginson]

See also NSS bug https://bugzilla.mozilla.org/show_bug.cgi?id=282610

Comment 2

[Rich Megginson]

Attachment: Diffs to use NSS SVRCORE

Not much here - it mostly just works as is.
I moved HAVE_SVRCORE into the "external" world since it is now an external
component.
I removed some old forte6 /s/b/c cruft from a Makefile.
I used DEFS+= instead of CFLAGS+= because CFLAGS was not working for me for
some reason and DEFS makes more sense.

Comment 3

[Mark Smith [:mcs]]

Comment on attachment 176213 [details]
Diffs to use NSS SVRCORE

Looks OK to me.  I am surprised there is a problem with CFLAGS though.

Comment 4

[Rich Megginson]

I am surprised too.  But this happened to me more than once (on Red Hat EL 3).
After this checkin, I'll do a quick review of bugs to see if there are any which
we should get in for DS 7.1.  Then I'll need to tag the tree.

Comment 5

[Rich Megginson]

Attachment: Newer diffs

Here is a better diff.	It also updates the components - NSS 3.9.3, NSPR 4.4.1,
DBM 1.61.

Comment 6

[Rich Megginson]

If these diffs are ok, I'd like to tag the tree.  I think the next release
number would be 5.15?  Is there anything I need to change in the ldapcsdk tree
to bump the version number?  The 5.15 release would contain: fix for getpassword
on HP-UX; allow use of open source SVRCORE; update component versions.

Comment 7

[Mark Smith [:mcs]]

Comment on attachment 176974 [details]
Newer diffs

The patch looks good.  Please commit.  The version can be set at build time,
which is what we have typically done in the past.  It would be nice to update
it in the source code too; just change the VENDOR_VERSION variable in
mozilla/directory/c-sdk/build.mk

Comment 8

[Mark Smith [:mcs]]

Make that DEFAULT_VENDOR_VERSION.

Comment 9

[Rich Megginson]

Done.