28279 - quoted text is wrapped and shouldn't be (long-short-long-short)

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Akkana Peck]

We're exhibiting the evil old long-short-long-short bug again!  Read a plaintext
message that has lines wrapped at around 72 columns, and reply to it in
plaintext.  Some of the quoted lines will be wrapped.

I was going to try debugging this, but you've turned off the debug menu in the
compose window, so I can't see what the html looks like.  The editor's
InsertAsQuotation is supposed to take care of that automatically, by turning
wrapping off for quoted text, so if you're calling InsertAsQuotation, it's my
bug (but please tell me how to turn on the debug menu so I can see what's going
on).  If you're not calling InsertAsQuotation, is there any reason why not
(something that you need from it that we're not providing)?

Comment 1

[Jean-Francois Ducarroz]

Akkana, you reactivate the debug menu by changing the line #362 in 
messengercompose.xul:

replace     <!-- menu id="debugMenu"/ -->
by          < menu id="debugMenu"/ >

I will look if we correctly insert the text tomorrow.

Comment 2

[Akkana Peck]

Thanks for the info on the debug menu!  And it turns out that mail compose is
calling the editor's InsertHTML function, so I'll take a look at what it's
doing.

Comment 3

[Akkana Peck]

This is really evil.  Marking M14 because it's more important than most of the
M15 list.

Comment 4

[Akkana Peck]

Adding a beta1 keyword ... even if it gets PDT-'ed, plaintext mail seems
important enough that I'd like to see it on the radar (and I bet the fix won't
be all that hard).

Comment 5

[leger]

Putting on PDT- radar for beta.

Comment 6

[Akkana Peck]

Requesting PDT re-evaluation of this bug: it's a regression, it makes plaintext
mail nasty to use (you have to do a lot of hand-editing to make things look
right), and it turns out that the fix is straightforward (a minor addition to
the text editing citation-splitting rules).  Joe and I have tested it on Mac and
Linux, and I'll be running with it in my tree to test it further.  Please, can
we check the fix into beta1?

Comment 7

[leger]

Putting on PDT+ radar because fix is in hand.

Comment 8

[Akkana Peck]

Thanks!  Adding date, will check it in tomorrow.

Comment 9

[Akkana Peck]

The tree is horked today and it's fairly clear that there's not going to be much
chance to test and check in, so I'm updating the date in the status whiteboard. 
The fix works as far as I can tell, but I'd like to run with it for a while, and
get a few other eyes testing it as well.

Comment 10

[Akkana Peck]

Fixed!  Plaintext quotations should work much better now, at least if Rich is
allowed to check in the fix for bug 29267.

Comment 11

[fenella]

inux (2000-02-29-08 M15)
Mac (2000-02-29-08 M15)
Win32 (2000-02-29-08 M15)
Read a plaintext message that has lines wrapped at around 72 columns, and reply
to it in plaintext.  The quoted lines wraps fine. I do not see lines wrap long
and short as explains to me by Akkana.