282796 - update rv and Firefox version numbers (as seen from About > Help)

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[sairuh (rarely reading bugmail)]

I was looking at the Help > About dialog for the 2005021706-1.0.1 firefox builds
on Windows and Mac and saw the following info in the version/user-agent string:

rv: 1.7.5
Firefox/1.0

shouldn't these be updated to rv: 1.7.6 and Firefox/1.0.1?

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I just updated the rv: from 1.7.5 to 1.7.6.

I'm a little more concerned about the FF version strings and their influence on
Update, extensions, etc.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So I guess the key question is, what does the following patch change, and is it
what we want?

Index: version.txt
===================================================================
RCS file: /cvs/mozilla/browser/config/version.txt,v
retrieving revision 1.1.4.7
diff -p -u -1 -2 -r1.1.4.7 version.txt
--- version.txt 27 Oct 2004 03:57:24 -0000      1.1.4.7
+++ version.txt 19 Feb 2005 02:16:21 -0000
@@ -1 +1 @@
-1.0
+1.0.1

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So I talked to Ben, and we found that app.extensions.version in firefox.js on
the branch is already fixed at 1.0, so bumping this should be OK.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: firefox patch

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: thunderbird patch

thunderbird also has the extensions version fixed in all-thunderbird.js.  If
we're even considering a thunderbird 1.0.1 off the
AVIARY_1_0_1_20050124_BRANCH, we should get this in sooner rather than later.

Comment 6

[Jay Patel [:jay]]

Comment on attachment 174757 [details] [diff] [review]
firefox patch

r=[e-mail]

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 174757 [details] [diff] [review]
firefox patch

sr/a=dveditz

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 174758 [details] [diff] [review]
thunderbird patch

sr/a=dveditz

Where does the Gecko rv: get bumped?

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The rv: is in config/milestone.txt, which I already landed.

Just checked in the other two.

Comment 10

[Jay Patel [:jay]]

Verified Fixed.  Version looks good:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050221
Firefox/1.0.1

Bug 283181 has been logged to rev the version number in the installer.