282980 - XPFE support for -help, -version, & -console on OS/2

Status: RESOLVED FIXED

(SeaMonkey :: General, enhancement)

Description

[Rich Walsh]

This is the xpfe version of Bug #282280 which implements an on-demand console
window for OS/2 and enables the use of the -help and -version commandline args.
 Like the xre version, it adds a new function that examines the commandline and
restarts the app if a console window is needed.

It also removes the -dde and -console args from the commandline to avoid losing
any URL that might follow them.  To accomplish this under xpfe, more extensive -
but minor - changes have been made to OS/2-specific code than were required for
the xre version.

Comment 1

[Rich Walsh]

Attachment: patch to implement console window under XPFE

Comment 2

[Rich Walsh]

Attachment: minor update to XPFE console window patch

Reverses the return value from StartOS2App():  TRUE if the app should start,
FALSE if it should terminate.  Also includes minor formatting changes.

Comment 3

[Mike Kaply [:mkaply]]

Finally got a chance to look at this.

-version and -help are crashing for me (although they "Work")

Console is working great.

the crash is in __eh_term__ so it has something with terminating the app?

Comment 4

[Rich Walsh]

(In reply to comment #3)
> -version and -help are crashing for me (although they "Work")
> Console is working great.
> the crash is in __eh_term__ so it has something with terminating the app?

This problem was recognized & fixed in XRE but not XPFE. Your FP exception
handler gets set but the unset call is bypassed by an early return (in this
case, after -help & -version are handled). Perhaps you should retrofit XPFE with
your ScopedExceptionHandler class (btw... is it Mozilla or Firefox that still
has FP problems?).

Comment 5

[Mike Kaply [:mkaply]]

Attachment: Fix exception handler scoping problem

Nice work Rich.

Here's the exception handler fix you mentioned.

Comment 6

[Mike Kaply [:mkaply]]

Fix checked in.