Closed Bug 282980 Opened 20 years ago Closed 20 years ago

XPFE support for -help, -version, & -console on OS/2

Categories

(SeaMonkey :: General, enhancement)

x86
OS/2
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dragtext, Assigned: mkaply)

Details

Attachments

(2 files, 1 obsolete file)

This is the xpfe version of Bug #282280 which implements an on-demand console
window for OS/2 and enables the use of the -help and -version commandline args.
 Like the xre version, it adds a new function that examines the commandline and
restarts the app if a console window is needed.

It also removes the -dde and -console args from the commandline to avoid losing
any URL that might follow them.  To accomplish this under xpfe, more extensive -
but minor - changes have been made to OS/2-specific code than were required for
the xre version.
Reverses the return value from StartOS2App():  TRUE if the app should start,
FALSE if it should terminate.  Also includes minor formatting changes.
Attachment #174958 - Attachment is obsolete: true
Finally got a chance to look at this.

-version and -help are crashing for me (although they "Work")

Console is working great.

the crash is in __eh_term__ so it has something with terminating the app?
(In reply to comment #3)
> -version and -help are crashing for me (although they "Work")
> Console is working great.
> the crash is in __eh_term__ so it has something with terminating the app?

This problem was recognized & fixed in XRE but not XPFE. Your FP exception
handler gets set but the unset call is bypassed by an early return (in this
case, after -help & -version are handled). Perhaps you should retrofit XPFE with
your ScopedExceptionHandler class (btw... is it Mozilla or Firefox that still
has FP problems?).
Nice work Rich.

Here's the exception handler fix you mentioned.
Attachment #176591 - Flags: superreview+
Attachment #176591 - Flags: review+
Fix checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: