283063 - leak domwindows when opening and closing tabs due to browser binding's focusedWindow member

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

When opening and closing tabs, the DOMWINDOW numbers don't go down until the
parent window is closed.  This is a leak that's freed when the containing window
is closed (rather than never freed).

One of the reasons for this (I think there are also some issues with the
browser:purge-session-history observers that I'll file as a separate bug once I
figure out what's going on a little better) is that the focusedWindow member of
the browser binding (which necessarily stays around until the parent window
closes, due to nsDocument::AddReference) is not nulled out.

Patch coming

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I'll add the "so we force a cleanup ourselves" back.  That was inadvertently
dropped.

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 175065 [details] [diff] [review]
patch

r=me, with the comment restored as noted

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in to trunk, 2005-02-21 14:50 -0800.

Comment 5

[Oliver Klee]

There is a typo in the patch: hapen -> happen