283180 - creativecommons, amazon, eBay, dictionary search plugins are broken for non-ASCII character search

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Jungshik Shin]

queryCharset is not specified in creativecommons.src so that it doesn't work for
non-ASCII characters.

Comment 1

[Jungshik Shin]

Attachment: patch

Comment 2

[Jungshik Shin]

Comment on attachment 175155 [details] [diff] [review]
patch

this is the same issue as bug 270120 (yahoo.src). note that creativecommons
uses UTF-8 by default so that there's no need to specify the encoding as an
input field. 

I should have fixed earlier and tried to make it in 1.0.1, but it's too late.

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 175155 [details] [diff] [review]
patch

Hmm.  I thought I asked in the other bug for Mano to double-check the other
plugins.  Maybe I didn't, oops...

Comment 4

[Phil Ringnalda (:philor)]

The rest (ebay, amazon, dictionary) are broken too, but less often: they all use
ISO-8859-1, so they only break for people who have set their default charset to
something other than that.

Comment 5

[Jungshik Shin]

Thanks for quick r. Fix landed.
As for the rest, we have to fix them, too. I wonder why I keep forgetting things.
Instead of filing a new bug, let's just fix them here before I forget :-)

Comment 6

[Jungshik Shin]

Attachment: patch part 2 (for the rest)

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 175273 [details] [diff] [review]
patch part 2 (for the rest)

Sweet.

Comment 8

[Steffen Wilberg]

Searchplugins have a silent autoupdate feature. The update location is specified
in their 'browser' section.

The Creative Commons plugins still refers to
http://mycroft.mozdev.org/plugins/creativecommons.src. We need to either fix
that as well, or use a mozilla.org location, like the other plugins.

http://www.mozilla.org/products/firefox/plugins/amazondotcom.src needs an update.
http://www.mozilla.org/products/firefox/plugins/dictionary.src is 404.
http://www.mozilla.org/products/firefox/plugins/ebay.src is 404.
http://www.mozilla.org/products/firefox/plugins/yahoo.src is 404.

http://lxr.mozilla.org/mozilla/source/browser/locales/en-US/searchplugins/google.src
doesn't have a browser section. It also says queryEncoding="utf-8", which is
bogus because queryEncoding is a decimal value:
http://lxr.mozilla.org/seamonkey/source/xpfe/components/search/src/nsInternetSearchService.cpp#2665
That line should be removed.

Comment 9

[Jungshik Shin]

Thanks for the note.
I updated amazondotcom.src at, added missing eBay, dictionary,yahoo to and fixed
google.src at http://www.mozilla.org/products/firefox/searchplugins. While doing
that, I bumped up the version number.

I also added creativecommons.src to mozdoc. Do we have to keep it there or let
that be taken care of by mycroft folks? mozdev bugzilla has been very erratic
these days. [1] We're shipping it with our products so that I think it's better
to keep it under our control, in which case I'll upload a patch soon.

Currently, google.src points to http://www.google.com/mozilla/google.src (well,
its update field is in search record). By the same token, we'd better keep it at
mozilla.org.


[1] http://bugzilla.mozdev.org/show_bug.cgi?id=9098

Comment 10

[Mike Connor [:mconnor]]

Let's split off the "where do we keep/point searchplugins" into a separate bug.
 I'm sure there's implications for localizers too, and I don't want to get too
far from the initial bug here.

We should keep control of this, just for the sake of keeping control of anything
we rely on, and as long as we maintain good relationships with the sites and
keep stuff up to date as needed that'll be fine.

Comment 11

[Jungshik Shin]

I agree with Mike. I filed bug 283787