Closed Bug 283237 Opened 21 years ago Closed 21 years ago

Move DBname_to_id out of globals.pl

Categories

(Bugzilla :: User Accounts, enhancement, P3)

2.19.2
enhancement

Tracking

()

RESOLVED FIXED
Bugzilla 2.20

People

(Reporter: mkanat, Assigned: mkanat)

References

Details

Attachments

(1 file)

Oh, this is going to be a big one. I think that it will go to Bugzilla::User, and be called login_to_id.
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.20
OK, here it is. Test suite passes, Bugzilla still works (from testing on landfill). LpSolit, if you get to this before wurblzap does, you can also feel free to review it. :-)
Attachment #175256 - Flags: review?(wurblzap)
Comment on attachment 175256 [details] [diff] [review] Move to Bugzilla::User::login_to_id The untainting seems unnecessary to me. I filed bug 283334 for that.
Attachment #175256 - Flags: review?(wurblzap) → review+
Flags: approval?
Blocks: 283334
Priority: -- → P3
Flags: approval? → approval+
Checking in editcomponents.cgi; /cvsroot/mozilla/webtools/bugzilla/editcomponents.cgi,v <-- editcomponents.cgi new revision: 1.48; previous revision: 1.47 done Checking in editusers.cgi; /cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v <-- editusers.cgi new revision: 1.77; previous revision: 1.76 done Checking in editwhines.cgi; /cvsroot/mozilla/webtools/bugzilla/editwhines.cgi,v <-- editwhines.cgi new revision: 1.4; previous revision: 1.3 done Checking in globals.pl; /cvsroot/mozilla/webtools/bugzilla/globals.pl,v <-- globals.pl new revision: 1.306; previous revision: 1.305 done Checking in importxml.pl; /cvsroot/mozilla/webtools/bugzilla/importxml.pl,v <-- importxml.pl new revision: 1.42; previous revision: 1.41 done Checking in Bugzilla/Bug.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v <-- Bug.pm new revision: 1.58; previous revision: 1.57 done Checking in Bugzilla/BugMail.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm,v <-- BugMail.pm new revision: 1.33; previous revision: 1.32 done Checking in Bugzilla/Flag.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v <-- Flag.pm new revision: 1.29; previous revision: 1.28 done Checking in Bugzilla/Search.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search.pm,v <-- Search.pm new revision: 1.83; previous revision: 1.82 done Checking in Bugzilla/User.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v <-- User.pm new revision: 1.38; previous revision: 1.37 done Checking in contrib/bug_email.pl; /cvsroot/mozilla/webtools/bugzilla/contrib/bug_email.pl,v <-- bug_email.pl new revision: 1.25; previous revision: 1.24 done Checking in contrib/sendbugmail.pl; /cvsroot/mozilla/webtools/bugzilla/contrib/sendbugmail.pl,v <-- sendbugmail.pl new revision: 1.3; previous revision: 1.2 done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: