28335 - Forcing handshake on CMT_OpenSSLConnection for https connections

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[Doug Turner (:dougt)]

I spoke with Mark today, and he stated that this was not needed for an https 
connection.  I propose this change:

*** 125,143 ****

      fd->secret = (PRFilePrivate *)secret;

      status = CMT_OpenSSLConnection(secret->control,
                                     secret->cmsock,
                                     SSM_REQUEST_SSL_DATA_SSL,
                                     PR_ntohs(addr->inet.port),
                                     ipBuffer,
                                     (char*)hostName,
!                                    CM_TRUE, //force handshake?  is this 
correct?
                                     nsnull);
--- 125,143 ----

      fd->secret = (PRFilePrivate *)secret;

      status = CMT_OpenSSLConnection(secret->control,
                                     secret->cmsock,
                                     SSM_REQUEST_SSL_DATA_SSL,
                                     PR_ntohs(addr->inet.port),
                                     ipBuffer,
                                     (char*)hostName,
!                                    CM_FALSE, 
                                     nsnull);


I got mwelch to review it.  I have tested with it, and it still appears to work.  
I would like to check in.

Comment 1

[sjlee]

This was possibly due to inadequate comments on the function in cmtcmn.h.  I 
added more comments today so that it is clear when this bit should be set.

Comment 2

[Doug Turner (:dougt)]

fix checked in.

Comment 3

[Doug Turner (:dougt)]

reopening.  not forcing handshake returns an immediate error.

Comment 4

[leger]

Does this break SSL?  What is user problem? Is there a workaround?

Comment 5

[Doug Turner (:dougt)]

removing beta1.  the work around is to just force handshaking.

Comment 6

[Doug Turner (:dougt)]

targeting m16.  If you reported this bug, and you would like to have it fixed 
sooner, please send me email.  I will see what I can do.  :-)

Comment 7

[Doug Turner (:dougt)]

per conversation with mwelch.

Comment 8

[Doug Turner (:dougt)]

back to me.

Comment 9

[Doug Turner (:dougt)]

making public.

Comment 10

[Doug Turner (:dougt)]

fix checked in.  Marking fixed.  

Comment 11

[John Unruh]

Verified fixed.