Forcing handshake on CMT_OpenSSLConnection for https connections

VERIFIED FIXED in M16

Status

()

P3
normal
VERIFIED FIXED
19 years ago
18 years ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

Trunk
x86
Windows NT
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

19 years ago
I spoke with Mark today, and he stated that this was not needed for an https 
connection.  I propose this change:

*** 125,143 ****

      fd->secret = (PRFilePrivate *)secret;

      status = CMT_OpenSSLConnection(secret->control,
                                     secret->cmsock,
                                     SSM_REQUEST_SSL_DATA_SSL,
                                     PR_ntohs(addr->inet.port),
                                     ipBuffer,
                                     (char*)hostName,
!                                    CM_TRUE, //force handshake?  is this 
correct?
                                     nsnull);
--- 125,143 ----

      fd->secret = (PRFilePrivate *)secret;

      status = CMT_OpenSSLConnection(secret->control,
                                     secret->cmsock,
                                     SSM_REQUEST_SSL_DATA_SSL,
                                     PR_ntohs(addr->inet.port),
                                     ipBuffer,
                                     (char*)hostName,
!                                    CM_FALSE, 
                                     nsnull);


I got mwelch to review it.  I have tested with it, and it still appears to work.  
I would like to check in.
(Assignee)

Updated

19 years ago
Group: netscapeconfidential?
Status: NEW → ASSIGNED
Keywords: beta1

Comment 1

19 years ago
This was possibly due to inadequate comments on the function in cmtcmn.h.  I 
added more comments today so that it is clear when this bit should be set.

Updated

19 years ago
Whiteboard: "fixed, reviewed and tested" - dougt
(Assignee)

Comment 2

19 years ago
fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

19 years ago
reopening.  not forcing handshake returns an immediate error.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: "fixed, reviewed and tested" - dougt

Comment 4

19 years ago
Does this break SSL?  What is user problem? Is there a workaround?
Whiteboard: [NEED INFO]
(Assignee)

Comment 5

19 years ago
removing beta1.  the work around is to just force handshaking.
Keywords: beta1
Whiteboard: [NEED INFO]
(Assignee)

Comment 6

19 years ago
targeting m16.  If you reported this bug, and you would like to have it fixed 
sooner, please send me email.  I will see what I can do.  :-)
Target Milestone: M16
(Assignee)

Comment 7

19 years ago
per conversation with mwelch.
Assignee: dougt → sjlee
Blocks: 13785
Status: REOPENED → NEW
(Assignee)

Comment 8

19 years ago
back to me.
Assignee: sjlee → dougt
(Assignee)

Comment 9

19 years ago
making public.
Group: netscapeconfidential?
(Assignee)

Comment 10

19 years ago
fix checked in.  Marking fixed.  
Status: NEW → RESOLVED
Last Resolved: 19 years ago19 years ago
Resolution: --- → FIXED

Updated

19 years ago
No longer blocks: 13785

Comment 11

18 years ago
Verified fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.