Closed Bug 28335 Opened 25 years ago Closed 25 years ago

Forcing handshake on CMT_OpenSSLConnection for https connections

Categories

(Core :: Networking, defect, P3)

x86
Windows NT
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

I spoke with Mark today, and he stated that this was not needed for an https connection. I propose this change: *** 125,143 **** fd->secret = (PRFilePrivate *)secret; status = CMT_OpenSSLConnection(secret->control, secret->cmsock, SSM_REQUEST_SSL_DATA_SSL, PR_ntohs(addr->inet.port), ipBuffer, (char*)hostName, ! CM_TRUE, //force handshake? is this correct? nsnull); --- 125,143 ---- fd->secret = (PRFilePrivate *)secret; status = CMT_OpenSSLConnection(secret->control, secret->cmsock, SSM_REQUEST_SSL_DATA_SSL, PR_ntohs(addr->inet.port), ipBuffer, (char*)hostName, ! CM_FALSE, nsnull); I got mwelch to review it. I have tested with it, and it still appears to work. I would like to check in.
Group: netscapeconfidential?
Status: NEW → ASSIGNED
Keywords: beta1
This was possibly due to inadequate comments on the function in cmtcmn.h. I added more comments today so that it is clear when this bit should be set.
Whiteboard: "fixed, reviewed and tested" - dougt
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
reopening. not forcing handshake returns an immediate error.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: "fixed, reviewed and tested" - dougt
Does this break SSL? What is user problem? Is there a workaround?
Whiteboard: [NEED INFO]
removing beta1. the work around is to just force handshaking.
Keywords: beta1
Whiteboard: [NEED INFO]
targeting m16. If you reported this bug, and you would like to have it fixed sooner, please send me email. I will see what I can do. :-)
Target Milestone: M16
per conversation with mwelch.
Assignee: dougt → sjlee
Blocks: 13785
Status: REOPENED → NEW
back to me.
Assignee: sjlee → dougt
making public.
Group: netscapeconfidential?
fix checked in. Marking fixed.
Status: NEW → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
No longer blocks: 13785
Verified fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.