283378 - certification-l10n (Sign-off) request for sq-AL Firefox 1.0.1

Status: RESOLVED WONTFIX

(Mozilla Localizations :: Other, defect)

Description

[Besnik Bleta]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; sq-AL; rv:1.8a6) Gecko/20050111
Build Identifier: 

Following a post of Chase, I'm filing a new bug to ask for sq-AL builds for
Firefox 1.0.1 to be signed-off 

Reproducible: Always

Comment 1

[Tracy Walker [:tracy]]

looks good on Windows aviary1.0.1-l10n-candidates for sq-AL

Comment 2

[sairuh (rarely reading bugmail)]

confirming and resetting the flags: tracy, I think we need to test linux and mac
before +ing this. I'll take a look at those builds soon.

Comment 3

[sairuh (rarely reading bugmail)]

I noticed bookmarks issues with the 20050223-1.0.1 builds:

a. with the linux build, there's an blank (unlabeled) empty folder. there is
also a blank (unlabeled) bookmark (the last one) pointing to
fxfeeds.mozillazine.org --it loads fine, but its label should not be blank.

b. with the linux build, there's also the blank, empty folder. however, the
fxfeeds bookmark is fine.

Tracy, do you see these on Windows sq-AL?

based on what I see, I'm going to minus this for now --pending further feedback
from Asa or Chase.

Comment 4

[sairuh (rarely reading bugmail)]

another observation for both mac and linux: the default size (while resizeable)
for the Preferences dialog is far too narrow.

Comment 5

[Tracy Walker [:tracy]]

Bookmarks on Windows are fine.  However, the Options dialog is also narrow on
Windows.

Comment 6

[sairuh (rarely reading bugmail)]

actually, I was getting the build from the wrong directory --need to look at
sq-AL 1.0.1 from latest-aviary1.0.1-l10n/

resetting nomination. will retest soon.

Comment 7

[sairuh (rarely reading bugmail)]

unfortunately, the (latest) 20050224-1.0.1 builds on Windows still show the same
bookmarks issue in comment 3.

will test linux later on; mac builds haven't been updated since 20050223,
though, so I'm not sure when those will become available for testing again.

Comment 8

[sairuh (rarely reading bugmail)]

testing 20050226-1.0.1, I still problems with the bookmarks (blank, empty folder
and blank bookmark to the livemarks product page) and preferences dialog size.

Comment 9

[Besnik Bleta]

Attachment: Patch for bookmarks.html

I reworked bookmarks.html found at the latest sq-AL.xpi against the one found
at en-US.xpi

Comment 10

[Besnik Bleta]

Attachment: patch for pref.dtd values related to Preferences' Dialog window size

almost doubled the values for width and height to make readable, without
resizing the window, the first appearance of Preferences dialog

Comment 11

[Chase Phillips]

Comment on attachment 175817 [details] [diff] [review]
Patch for bookmarks.html

Clearing approval-aviary1.0.1 flag.  Please only use approval-l10n.

Comment 12

[Chase Phillips]

Comment on attachment 175819 [details] [diff] [review]
patch for pref.dtd values related to Preferences' Dialog window size 

Clearing approval-aviary1.0.1 flag.  Please only use approval-l10n.

Comment 13

[sairuh (rarely reading bugmail)]

hi Besnik, once your patches are checked in, could you please reset the
certification-l10n flag to '?' --that way we can retest it. thanks!

Comment 14

[Axel Hecht]

Comment on attachment 175817 [details] [diff] [review]
Patch for bookmarks.html

Please read http://wiki.mozilla.org/wiki/L10n:Firefox_Extras#Bookmarks on how
to localize bookmarks.html

Comment 15

[Axel Hecht]

Comment on attachment 175819 [details] [diff] [review]
patch for pref.dtd values related to Preferences' Dialog window size 

Please fix
http://lxr.mozilla.org/l10n-aviarybranch/source/toolkit/locales/sq-AL/chrome/mo
zapps/profile/createProfileWizard.dtd, too.

Comment 16

[Axel Hecht]

I did a 

find */locales/en-US -type f|xargs grep "width:"
and a 
find */locales/en-US -type f|xargs grep "height:"

which found 

browser/locales/en-US/chrome/browser/pref/pref.dtd and
toolkit/locales/en-US/chrome/mozapps/profile/createProfileWizard.dtd

I hope that I caught all occurences.

Comment 17

[Besnik Bleta]

Attachment: fixing links on bookmarks.html which should be localized

Comment 18

[Besnik Bleta]

Attachment: patching width & height for createProfileWizard dialog windows

Comment 19

[Axel Hecht]

Comment on attachment 175859 [details]
patching width & height for createProfileWizard dialog windows

<MMx> Pike: _80_ em height? you need a 20" TFT or something like it to fit

Sounds like the sizes are way off. Size does matter, but it's not necessarily
the bigger the better.
If you can't test it, use the en-US sizes and QA the generated builds.

Comment 20

[Besnik Bleta]

I should done the test before submitting any patch for createProfil dialog...
It works fine as it is now.

Comment 21

[Besnik Bleta]

Attachment: scaled width & height to 65x45 em (see 175819)

Could'n test the new settings above for width & height of preferences dialog.
Changes made comparing broadly to fr-FR, de-De and it-IT.
(Pike, the values used on actual build are the ones used on en-US.)

Comment 22

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 175946 [details] [diff] [review]
scaled width & height to 65x45 em (see 175819)

you cannot translate "width" and "height" keywords since those are CSS
properties.

Comment 23

[Axel Hecht]

Attachment: fix the three not-to-translate issues

As I laid out in https://bugzilla.mozilla.org/show_bug.cgi?id=283325#c52, there

are a few required fixes. I tested the dialog window sizes on sq-AL on windows,

and they're perfectly fine in the en-US sizes AFAICT.

Besnik, would you note a review on this patch here?

Comment 24

[Besnik Bleta]

Attachment: width & height

Comment 25

[Besnik Bleta]

(In reply to comment #23)
> Created an attachment (id=176041) [edit]
> fix the three not-to-translate issues
> 
> As I laid out in https://bugzilla.mozilla.org/show_bug.cgi?id=283325#c52, there
> 
> are a few required fixes. I tested the dialog window sizes on sq-AL on windows,
> 
> and they're perfectly fine in the en-US sizes AFAICT.
> 
> Besnik, would you note a review on this patch here?

Pike, all the three fixes are fine. Thanks a lot for your help.
(But I'm still confused about the values of width & height.
Wasn't I being asked to increase the values which you now find OK?)
If you think those values are OK, go head.

Comment 26

[Axel Hecht]

(In reply to comment #25)

> Pike, all the three fixes are fine. Thanks a lot for your help.
> (But I'm still confused about the values of width & height.
> Wasn't I being asked to increase the values which you now find OK?)

Oh, misunderstanding. As you translated width and height, they didn't get picked 
up by layout at all, which rendered the dialogs too small. Once those are not
translated, the layout picks up the values and the en-US values actually work
for your locale as well.

Comment 27

[Axel Hecht]

Comment on attachment 176064 [details] [diff] [review]
width & height 

we'll take the other one, then

Comment 28

[Axel Hecht]

Comment on attachment 176041 [details] [diff] [review]
fix the three not-to-translate issues

this one should land

Comment 29

[Axel Hecht]

Comment on attachment 176041 [details] [diff] [review]
fix the three not-to-translate issues

checked this one in.

sorry for the delay

Comment 30

[Besnik Bleta]

I tested 1.0.3 builds and those look fine tome. Could you test and hopefully
publish them?


(In reply to comment #13)
> hi Besnik, once your patches are checked in, could you please reset the
> certification-l10n flag to '?' --that way we can retest it. thanks!

Comment 31

[Simon Paquet [:sipaq]]

What is the status of this bug?

Comment 32

[Besnik Bleta]

I think this should be closed: we´re not working anymore for a 1.0.1 release.