283567 - Toggling a comment's privacy does nothing

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Max Kanat-Alexander]

On today's tip, if I uncheck the "private" box on a comment, it doesn't become
un-private. If I check the "private" box, it doesn't become private.

I can file a new private comment, or make a new private attachment, but once
something is private I can't make it "un-private." Once something is
"un-private", I can't make it private.

Comment 1

[Frédéric Buclin]

This is because the hidden when-# field is empty. It should contain the date of
the comment. May be related to $dbh->sql_date_format('longdescs.bug_when',
'%Y%m%d%H%i%s') in Bug.pm, line 541.

process_bug.cgi is clean, so the problem is to get the date of the comment from
the DB.

I haven't time right now, so if someone wants to take it, please do. Else I do
it with "pleasure" when I come back.

Comment 2

[Joel Peshkin]

That's exactly why longdescs needs a good key

Comment 3

[Frédéric Buclin]

Attachment: adding AS bug_when, v1

There is a missing "AS bug_when" in GetComments(). This is a regression from
bug 279700 caused by... mkanat! :)

Comment 4

[Max Kanat-Alexander]

Comment on attachment 175773 [details] [diff] [review]
adding AS bug_when, v1

Yeah. This is right. But don't change all the code -- just fix the line that
needs fixing. Just resubmit a new patch with only the one line changed.

The funny part is that it seemed to be working when I ran my tests on it... ah,
well. :-)

Comment 5

[Frédéric Buclin]

Attachment: adding AS bug_when, v2

Do you prefer this version?

Comment 6

[Max Kanat-Alexander]

Comment on attachment 175836 [details] [diff] [review]
adding AS bug_when, v2

Very much. -)

Comment 7

[Shane H. W. Travis]

Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.60; previous revision: 1.59
done